Differential D1924

core: move credentials' docstring from request_params to request_instance_credentials
ClosedPublic
Actions

Authored by douardda on Aug 30 2019, 6:01 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

rDLS6f56d2c8d72d: core: move credentials' docstring from request_params to…

Summary

and fix empty values returned by this later (empty list instead of ampty dict).

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Aug 30 2019, 6:01 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 30 2019, 6:01 PM

douardda added a child revision: D1925: phabricator: kill PhabricatorLister's api_token argument.Aug 30 2019, 6:01 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/309/ for more details.

Harbormaster completed remote builds in B7536: Diff 6480.Aug 30 2019, 6:03 PM

ardumont accepted this revision.Aug 31 2019, 7:53 AM

This revision is now accepted and ready to land.Aug 31 2019, 7:53 AM

Closed by commit rDLS6f56d2c8d72d: core: move credentials' docstring from request_params to… (authored by douardda). · Explain WhySep 2 2019, 10:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

lister/

core/

lister_transports.py

57 lines

Diff 6492

swh/lister/core/lister_transports.py

Loading...