Differential D1926

phabricator: small refactoring/simplification of the request_params method
ClosedPublic
Actions

Authored by douardda on Aug 30 2019, 6:02 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLS814779404ccb: phabricator: small refactoring/simplification of the request_params method

Summary

and get rid of the unneeded _build_query_params method.

Depends on D1925

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Aug 30 2019, 6:02 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 30 2019, 6:02 PM

douardda added a child revision: D1927: phabricator: randomly select the API token in the provided list.Aug 30 2019, 6:02 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/311/ for more details.

Harbormaster completed remote builds in B7538: Diff 6482.Aug 30 2019, 6:07 PM

simpler!

This revision is now accepted and ready to land.Aug 31 2019, 7:55 AM

Closed by commit rDLS814779404ccb: phabricator: small refactoring/simplification of the request_params method (authored by douardda). · Explain WhySep 2 2019, 10:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

lister/

phabricator/

lister.py

16 lines

Diff 6494

View Options

swh/lister/phabricator/lister.py

phabricator: small refactoring/simplification of the request_params methodClosedPublicActions