Page MenuHomeSoftware Heritage

tasks: normalize the url argument name of most lister
ClosedPublic

Authored by douardda on Wed, Sep 4, 11:53 AM.

Details

Summary

Since all the listing tasks accepts an url as first argument (whatever the
argument name is), it makes sense to use a simple common argument name for
this. I've chosen 'url' instead of api_baseurl/forge_url/url.

Also kill now useless new_lister() functions.

Depends on D1949

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Wed, Sep 4, 11:53 AM
douardda updated this revision to Diff 6574.Wed, Sep 4, 2:38 PM

change of plan: use 'url' argument everywhere

This will require a migration script in prod...

ardumont accepted this revision.Wed, Sep 4, 3:01 PM
This revision is now accepted and ready to land.Wed, Sep 4, 3:01 PM
douardda retitled this revision from tasks: make tasks accept positional arguments to tasks: normalize the url argument name of most lister.Wed, Sep 4, 3:42 PM
douardda edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.