tasks: normalize the url argument name of most lister
ClosedPublic
Actions

Authored by douardda on Sep 4 2019, 11:53 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLSb810876ef827: tasks: normalize the url argument name of most lister

Summary

Since all the listing tasks accepts an url as first argument (whatever the
argument name is), it makes sense to use a simple common argument name for
this. I've chosen 'url' instead of api_baseurl/forge_url/url.

Also kill now useless new_lister() functions.

Depends on D1949

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 4 2019, 11:53 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 4 2019, 11:53 AM

Harbormaster failed remote builds in B7638: Diff 6563!Sep 4 2019, 11:55 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/344/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/344/console

change of plan: use 'url' argument everywhere

This will require a migration script in prod...

Harbormaster failed remote builds in B7649: Diff 6574!Sep 4 2019, 2:38 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/345/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/345/console

ardumont accepted this revision.Sep 4 2019, 3:01 PM

This revision is now accepted and ready to land.Sep 4 2019, 3:01 PM

douardda retitled this revision from tasks: make tasks accept positional arguments to tasks: normalize the url argument name of most lister.Sep 4 2019, 3:42 PM

douardda edited the summary of this revision. (Show Details)

rebase

Harbormaster failed remote builds in B7661: Diff 6586!Sep 4 2019, 3:44 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/351/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/351/console