- use the 'standard' api_baseurl as init argument,
- make it optional, with default to forge.softwareheritage.org,
- use origin_url as id.
Depends on D1933
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDLS87cec2f5c39e: phabricator: refactor PhabricatorLister's constructor
Diff Detail
Diff Detail
- Repository
- rDLS Listers
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/319/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/319/console
| swh/lister/phabricator/lister.py | ||
|---|---|---|
| 23 | I forgot to mention to check the tasks module. i think it's broken now as it explicits the forge_url there (in my current local version though at least ;) I'm not sure where this is coming from (it should but i don't think it is coming from the plugin refactoring yet). | |
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/326/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/326/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/332/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/332/console
| swh/lister/phabricator/lister.py | ||
|---|---|---|
| 23 | @dourdda sadly, I was right! :) After tagging the new scheduler (and rebuilding docker container) swh-lister_1 | File "/srv/softwareheritage/venv/lib/python3.7/site-packages/swh/lister/cli.py", line 116, in get_lister swh-lister_1 | override_config=override_conf) swh-lister_1 | TypeError: __init__() got an unexpected keyword argument 'forge_url' I'll fix that ;) | |