Page MenuHomeSoftware Heritage

phabricator: refactor PhabricatorLister's constructor
ClosedPublic

Authored by douardda on Fri, Aug 30, 6:05 PM.

Details

Summary
  • use the 'standard' api_baseurl as init argument,
  • make it optional, with default to forge.softwareheritage.org,
  • use origin_url as id.

Depends on D1933

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Fri, Aug 30, 6:05 PM
ardumont accepted this revision.Sun, Sep 1, 11:08 AM
This revision is now accepted and ready to land.Sun, Sep 1, 11:08 AM
ardumont added inline comments.Mon, Sep 2, 11:17 AM
swh/lister/phabricator/lister.py
23

I forgot to mention to check the tasks module.

i think it's broken now as it explicits the forge_url there (in my current local version though at least ;)

I'm not sure where this is coming from (it should but i don't think it is coming from the plugin refactoring yet).

This revision was landed with ongoing or failed builds.Mon, Sep 2, 1:17 PM
This revision was automatically updated to reflect the committed changes.
ardumont added inline comments.Tue, Sep 3, 11:01 AM
swh/lister/phabricator/lister.py
23

@dourdda sadly, I was right! :)

After tagging the new scheduler (and rebuilding docker container)

swh-lister_1                  |   File "/srv/softwareheritage/venv/lib/python3.7/site-packages/swh/lister/cli.py", line 116, in get_lister
swh-lister_1                  |     override_config=override_conf)
swh-lister_1                  | TypeError: __init__() got an unexpected keyword argument 'forge_url'

I'll fix that ;)