Page MenuHomeSoftware Heritage

core: make it possible to specify the api_baseurl init argument in override_config
ClosedPublic

Authored by douardda on Fri, Aug 30, 6:03 PM.

Details

Summary

This is required to be able to make lister classes instanciation easier and more
reliable, especially in the context of cli tools like 'swh lister run', for which
we want to be able to specify any lister init argument as extra parameter of the
command.

Depends on D1929

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Fri, Aug 30, 6:03 PM

That simplifies and unifies the lister instantiation, /me likes.
I also agree with all the other diffs depending on this diff.
Thanks.


I guess the build failure is because you'll change the cli call later (get_lister is currently unhappy) or is that an arc patch order missed from jenkins?

ardumont accepted this revision.Sun, Sep 1, 11:06 AM
This revision is now accepted and ready to land.Sun, Sep 1, 11:06 AM
This revision was landed with ongoing or failed builds.Mon, Sep 2, 1:17 PM
This revision was automatically updated to reflect the committed changes.