Page MenuHomeSoftware Heritage
Feed Advanced Search

Feb 23 2022

anlambert closed T3967: "Link" header is not properly displayed in apidoc when it contains [] as Resolved.

Fixed and deployed to production.

Feb 23 2022, 5:39 PM · Web app
anlambert created P1301 (An Untitled Masterwork).
Feb 23 2022, 5:01 PM
anlambert closed D7231: requirements-test: Move ImportError workarounds in it.
Feb 23 2022, 4:21 PM
anlambert committed rDWAPPS29bf07ecfeab: requirements-test: Move ImportError workarounds in it (authored by anlambert).
requirements-test: Move ImportError workarounds in it
Feb 23 2022, 4:21 PM
anlambert requested review of D7231: requirements-test: Move ImportError workarounds in it.
Feb 23 2022, 4:07 PM
anlambert created P1299 (An Untitled Masterwork).
Feb 23 2022, 3:29 PM
anlambert closed D7224: misc/coverage: Use django cache instead of LRU ones.
Feb 23 2022, 1:07 PM
anlambert committed rDWAPPS7b917f18fd15: misc/coverage: Use django cache instead of LRU ones (authored by anlambert).
misc/coverage: Use django cache instead of LRU ones
Feb 23 2022, 1:07 PM
anlambert closed D7223: common/utils: Add utility functions to check swh-web run environment.
Feb 23 2022, 1:07 PM
anlambert committed rDWAPPScc5736263984: common/utils: Add utility functions to check swh-web run environment (authored by anlambert).
common/utils: Add utility functions to check swh-web run environment
Feb 23 2022, 1:07 PM
anlambert updated the diff for D7224: misc/coverage: Use django cache instead of LRU ones.

Return adequate default value when value is not in cache.

Feb 23 2022, 11:25 AM
anlambert accepted D7226: deposit-list: Allow listing of deposit with their raw metadata if any.
Feb 23 2022, 11:21 AM
anlambert updated the summary of D7224: misc/coverage: Use django cache instead of LRU ones.
Feb 23 2022, 11:12 AM
anlambert added inline comments to D7226: deposit-list: Allow listing of deposit with their raw metadata if any.
Feb 23 2022, 11:07 AM

Feb 22 2022

anlambert updated the diff for D7224: misc/coverage: Use django cache instead of LRU ones.

Update comment in test

Feb 22 2022, 7:52 PM
anlambert retitled D7224: misc/coverage: Use django cache instead of LRU ones from misc/coverage: misc/coverage: Use django cache instead of LRU ones to misc/coverage: Use django cache instead of LRU ones.
Feb 22 2022, 7:50 PM
anlambert retitled D7224: misc/coverage: Use django cache instead of LRU ones from misc/coverage: Bypass LRU caches when not in production to misc/coverage: misc/coverage: Use django cache instead of LRU ones.
Feb 22 2022, 7:50 PM
anlambert updated the diff for D7224: misc/coverage: Use django cache instead of LRU ones.

Use django cache instead of LRU caches.

Feb 22 2022, 7:49 PM
anlambert added a comment to D7224: misc/coverage: Use django cache instead of LRU ones.

This code feels rather weird. I think you should get rid of the lru_cache decorator on _get_listers_metrics, and implement caching directly in _get_listers_metrics, with a boolean argument to toggle it.

Feb 22 2022, 7:14 PM
anlambert updated the diff for D7224: misc/coverage: Use django cache instead of LRU ones.

Fix typo in comment

Feb 22 2022, 5:50 PM
anlambert requested review of D7224: misc/coverage: Use django cache instead of LRU ones.
Feb 22 2022, 5:44 PM
anlambert requested review of D7223: common/utils: Add utility functions to check swh-web run environment.
Feb 22 2022, 5:40 PM
anlambert closed D7221: misc/coverage: Display counters for bzr/cvs visit types conditionally.
Feb 22 2022, 3:31 PM
anlambert committed rDWAPPSc14cfd1b2814: misc/coverage: Display counters for bzr/cvs visit types conditionally (authored by anlambert).
misc/coverage: Display counters for bzr/cvs visit types conditionally
Feb 22 2022, 3:31 PM
anlambert added inline comments to D7221: misc/coverage: Display counters for bzr/cvs visit types conditionally.
Feb 22 2022, 3:24 PM
anlambert renamed CVS loader from CVS Loader to CVS loader.
Feb 22 2022, 3:13 PM
anlambert renamed CVS loader from Loader-CVS to CVS Loader.
Feb 22 2022, 3:12 PM
anlambert added a revision to T3945: staging: List and ingest bzr origins, analyse and fix paper cuts: D7221: misc/coverage: Display counters for bzr/cvs visit types conditionally.
Feb 22 2022, 3:04 PM · BZR loader
anlambert added a revision to T3835: staging: Ingest sourceforge cvs origins: D7221: misc/coverage: Display counters for bzr/cvs visit types conditionally.
Feb 22 2022, 3:04 PM · CVS loader, Archive coverage
anlambert closed D7219: docs/Makefile: Fix warning about file not being included in any toctree.
Feb 22 2022, 2:29 PM
anlambert committed rDDOC6aa5f08095e9: docs/Makefile: Fix warning about file not being included in any toctree (authored by anlambert).
docs/Makefile: Fix warning about file not being included in any toctree
Feb 22 2022, 2:29 PM
anlambert requested review of D7219: docs/Makefile: Fix warning about file not being included in any toctree.
Feb 22 2022, 2:20 PM
anlambert accepted D7218: docs/index: Reference the bzr loader.
Feb 22 2022, 2:07 PM
anlambert closed D7213: common/swh_templatetags: Fix parsing issue in urlize_header_links.
Feb 22 2022, 11:18 AM
anlambert committed rDWAPPS937a1d59c592: common/swh_templatetags: Fix parsing issue in urlize_header_links (authored by anlambert).
common/swh_templatetags: Fix parsing issue in urlize_header_links
Feb 22 2022, 11:18 AM

Feb 21 2022

anlambert closed T3839: Optimize SVN loader performance and memory consumption on large repositories as Resolved.

Fixed and deployed.

Feb 21 2022, 6:41 PM · SVN Loader
anlambert closed T3896: Properly handle loading of repository sub-tree as Resolved.

Fixed and deployed.

Feb 21 2022, 6:40 PM · SVN Loader
anlambert requested review of D7213: common/swh_templatetags: Fix parsing issue in urlize_header_links.
Feb 21 2022, 6:16 PM
anlambert added a revision to T3967: "Link" header is not properly displayed in apidoc when it contains []: D7213: common/swh_templatetags: Fix parsing issue in urlize_header_links.
Feb 21 2022, 5:43 PM · Web app
anlambert closed D7207: requirements: Workaround another ImportError when running pytest.
Feb 21 2022, 2:20 PM
anlambert committed rDWAPPS55aa143db84a: requirements: Workaround another ImportError when running pytest (authored by anlambert).
requirements: Workaround another ImportError when running pytest
Feb 21 2022, 2:20 PM
anlambert closed D7206: requirements-test: Bump pytest-postgresql.
Feb 21 2022, 2:19 PM
anlambert committed rDDEPe1549dc0d3d9: requirements-test: Bump pytest-postgresql (authored by anlambert).
requirements-test: Bump pytest-postgresql
Feb 21 2022, 2:19 PM
anlambert closed D7202: loader: Upgrade repository with old formats prior loading.
Feb 21 2022, 2:16 PM
anlambert committed rDLDBZR77fd211f4ded: loader: Upgrade repository with old formats prior loading (authored by anlambert).
loader: Upgrade repository with old formats prior loading
Feb 21 2022, 2:16 PM
anlambert requested review of D7207: requirements: Workaround another ImportError when running pytest.
Feb 21 2022, 2:13 PM
anlambert added a comment to D7202: loader: Upgrade repository with old formats prior loading.

Should this be folded with the patch in T3963#79379?

Feb 21 2022, 2:00 PM
anlambert requested review of D7206: requirements-test: Bump pytest-postgresql.
Feb 21 2022, 1:43 PM
anlambert added a project to T3923: Include submodules recursively when saving git repositories: Git loader.
Feb 21 2022, 1:32 PM · Git loader, Save Code Now

Feb 18 2022

anlambert updated the diff for D7202: loader: Upgrade repository with old formats prior loading.

Remove no longer used RepositoryNeedsUpgrade exception

Feb 18 2022, 5:23 PM
anlambert added inline comments to D7202: loader: Upgrade repository with old formats prior loading.
Feb 18 2022, 5:22 PM
anlambert closed D7205: requirements: Workaround ImportError when running pytest.
Feb 18 2022, 5:20 PM
anlambert committed rDWAPPSf7b35626cb3b: requirements: Workaround ImportError when running pytest (authored by anlambert).
requirements: Workaround ImportError when running pytest
Feb 18 2022, 5:20 PM
anlambert updated the summary of D7205: requirements: Workaround ImportError when running pytest.
Feb 18 2022, 5:14 PM
anlambert requested review of D7205: requirements: Workaround ImportError when running pytest.
Feb 18 2022, 5:11 PM
anlambert requested review of D7202: loader: Upgrade repository with old formats prior loading.
Feb 18 2022, 3:58 PM
anlambert added a revision to T3945: staging: List and ingest bzr origins, analyse and fix paper cuts: D7202: loader: Upgrade repository with old formats prior loading.
Feb 18 2022, 3:53 PM · BZR loader
anlambert accepted D7199: Let the log instruction do the formatting.
Feb 18 2022, 12:52 PM
anlambert committed rDWAPPS213828bfd4fd: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Feb 18 2022, 11:06 AM
anlambert closed D7197: browse/utils: Robustify content encoding detection.
Feb 18 2022, 11:06 AM
anlambert committed rDWAPPSd9944bdd56c4: browse/utils: Robustify content encoding detection (authored by anlambert).
browse/utils: Robustify content encoding detection
Feb 18 2022, 11:06 AM
anlambert accepted D7198: launchpad: Ignore erratic page and continue listing.
Feb 18 2022, 10:40 AM
anlambert added a comment to D7198: launchpad: Ignore erratic page and continue listing.

So after some tests, what I proposed in D7198#187379 simply does not work as iterators cannot be retried.

Feb 18 2022, 10:39 AM

Feb 17 2022

anlambert requested changes to D7198: launchpad: Ignore erratic page and continue listing.

I misunderstood what is the repos object in the code so we did not use the throttling_retry decorator the right way.

Feb 17 2022, 10:21 PM
anlambert requested review of D7197: browse/utils: Robustify content encoding detection.
Feb 17 2022, 5:23 PM
anlambert closed D7186: sourceforge: Fix origin URLs for CVS projects.
Feb 17 2022, 1:55 PM
anlambert committed rDLS6a7479553e6b: sourceforge: Fix origin URLs for CVS projects (authored by anlambert).
sourceforge: Fix origin URLs for CVS projects
Feb 17 2022, 1:55 PM
anlambert updated the diff for D7186: sourceforge: Fix origin URLs for CVS projects.

Rebase

Feb 17 2022, 1:52 PM
anlambert accepted D7196: lauchpad: review adaptations.
Feb 17 2022, 1:12 PM
anlambert accepted D7194: lauchpad: Manage unhandled exception when listing.

Looks good to me.

Feb 17 2022, 1:11 PM
anlambert added inline comments to D7194: lauchpad: Manage unhandled exception when listing.
Feb 17 2022, 12:12 PM
anlambert added inline comments to D7194: lauchpad: Manage unhandled exception when listing.
Feb 17 2022, 12:03 PM
anlambert requested changes to D7194: lauchpad: Manage unhandled exception when listing.
Feb 17 2022, 11:25 AM
anlambert requested changes to D7195: lauchpad: Manage unhandled exception when reading page of result.
Feb 17 2022, 11:23 AM
anlambert accepted D7193: launchpad: Allow bzr origins listing.

Looks good to me, I added some nitpick comments.

Feb 17 2022, 11:09 AM

Feb 16 2022

anlambert accepted D7191: staging: Actually schedule bzr and cvs repositories in scn.

Great, thanks !

Feb 16 2022, 3:46 PM
anlambert accepted D7183: Use ':' for substring matching instead of '='.

IMO ~ implies some sort of regexp or glob match, but here this is essentially a substring search. : is consistent with the syntax used by Google, Bing, DDG, ...

Feb 16 2022, 12:10 PM
anlambert updated the diff for D7186: sourceforge: Fix origin URLs for CVS projects.

Bump log from debug to warning.

Feb 16 2022, 12:08 PM
anlambert added inline comments to D7186: sourceforge: Fix origin URLs for CVS projects.
Feb 16 2022, 12:07 PM
anlambert closed D7187: docker/conf/lister: Add sourceforge listing tasks.
Feb 16 2022, 12:03 PM
anlambert committed rDENV5c64a46ed699: docker/conf/lister: Add sourceforge listing tasks (authored by anlambert).
docker/conf/lister: Add sourceforge listing tasks
Feb 16 2022, 12:03 PM
anlambert added a comment to D7183: Use ':' for substring matching instead of '='.

only : is still confusing to me, how about using := or ~ instead ?

Feb 16 2022, 12:02 PM
anlambert accepted D7185: grammar: Prevent 'isoDateTime' rule from being too greedy.
Feb 16 2022, 11:53 AM
anlambert accepted D7184: translator: Fix 'visited = false' queries to actually return results..

Looks good to me, it is related to T3927 right ?

Feb 16 2022, 11:50 AM
anlambert requested review of D7187: docker/conf/lister: Add sourceforge listing tasks.
Feb 16 2022, 11:43 AM
anlambert requested review of D7186: sourceforge: Fix origin URLs for CVS projects.
Feb 16 2022, 11:42 AM
anlambert added a revision to T3789: Adapt sourceforge lister to list cvs origins according to what the cvs loader expects: D7186: sourceforge: Fix origin URLs for CVS projects.
Feb 16 2022, 11:39 AM · CVS loader, Archive coverage

Feb 15 2022

anlambert accepted D7181: staging: Allow cvs repo to be loaded through save code now.

Thanks !

Feb 15 2022, 5:51 PM
anlambert added a comment to D7177: Revert "package/loader: Remove no longer needed type ignore comment".

My bad, I had latest mypy (0.931) installed in my venv and it complained about the comment, but it is still needed for mypy 0.920.

Feb 15 2022, 4:07 PM
anlambert closed D7175: docker: Cleanup dockerfile.
Feb 15 2022, 3:17 PM
anlambert closed D7176: docker: Enable CVS loader use in docker environment.
Feb 15 2022, 3:17 PM
anlambert committed rDENV3e432fc8c754: docker: Enable CVS loader use in docker environment (authored by anlambert).
docker: Enable CVS loader use in docker environment
Feb 15 2022, 3:17 PM
anlambert committed rDENVfb22ac873652: docker: Cleanup dockerfile (authored by anlambert).
docker: Cleanup dockerfile
Feb 15 2022, 3:17 PM
anlambert updated the diff for D7176: docker: Enable CVS loader use in docker environment.

Rebase

Feb 15 2022, 3:17 PM
anlambert updated the diff for D7175: docker: Cleanup dockerfile.

Rebase

Feb 15 2022, 3:17 PM
anlambert created P1291 (An Untitled Masterwork).
Feb 15 2022, 2:46 PM
anlambert updated the diff for D7176: docker: Enable CVS loader use in docker environment.

Reorder loader modules in pip install command.

Feb 15 2022, 2:35 PM
anlambert requested review of D7176: docker: Enable CVS loader use in docker environment.
Feb 15 2022, 2:31 PM
anlambert requested review of D7175: docker: Cleanup dockerfile.
Feb 15 2022, 2:15 PM
anlambert accepted D7169: api_origin_search: Copy all params to build 'link-next'..
Feb 15 2022, 11:08 AM