Page MenuHomeSoftware Heritage

Revert "package/loader: Remove no longer needed type ignore comment"
ClosedPublic

Authored by ardumont on Feb 15 2022, 4:04 PM.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7177 (id=26011)

Rebasing onto 4ead2b60c5...

Current branch diff-target is up to date.
Changes applied before test
commit 9c3506663e5a23c6fa3e2881d29511b60bde2b3f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Feb 15 16:03:39 2022 +0100

    Revert "package/loader: Remove no longer needed type ignore comment"
    
    This reverts commit 4ead2b60c56ad91196c8c6aea148d1162bcce63d to fix the master build [1]
    
    [1] https://jenkins.softwareheritage.org/view/swh-draft/job/DLDBASE/job/tests/1817/console

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/694/ for more details.

vlorentz added a subscriber: vlorentz.

thank you mypy

This revision is now accepted and ready to land.Feb 15 2022, 4:06 PM

My bad, I had latest mypy (0.931) installed in my venv and it complained about the comment, but it is still needed for mypy 0.920.