Page MenuHomeSoftware Heritage

deposit-list: Allow listing of deposit with their raw metadata if any
ClosedPublic

Authored by ardumont on Feb 22 2022, 6:45 PM.

Details

Summary

This will allow adaptations in the moderation view [1] to display the metadata
provenance url (provided it's parsed out of the raw metadata).

[1] The moderation view actually consumes this internal api.

Related to T3677

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7226 (id=26186)

Rebasing onto 55ae87b13c...

Current branch diff-target is up to date.
Changes applied before test
commit 85bd09954679ce4d2fbce10c827a6fdf83e7fa45
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Feb 22 18:41:45 2022 +0100

    deposit-list: Allow listing of deposit with their raw metadata if any
    
    This will allow adaptations in the moderation view [1] to display the metadata
    provenance url (provided it's parsed out of the raw metadata).
    
    [1] The moderation view actually consumes this internal api.
    
    Related to T3677

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/731/ for more details.

Improve deposit listing test to demonstrate either there is raw metadata and it's
included in the listing, or there is none and it remains empty.

Build is green

Patch application report for D7226 (id=26189)

Rebasing onto 55ae87b13c...

Current branch diff-target is up to date.
Changes applied before test
commit acc02d1bc0dacad75e939d76def1e3e30a3b0aaf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Feb 22 18:41:45 2022 +0100

    deposit-list: Allow deposit listing with their raw metadata if any
    
    This now lists the deposit with their associated raw metadata if any is present. This
    will allow adaptations in the moderation view [1] to display the metadata provenance
    url (provided it's parsed out of the raw metadata).
    
    [1] The moderation view consumes this internal api.
    
    Related to T3677

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/732/ for more details.

swh/deposit/api/private/deposit_list.py
50

Can we have more than one metadata associated to a deposit ? If yes, should we not return them all ?

swh/deposit/api/private/deposit_list.py
50

good question, a recent change is to actually take the latest one D7211, so it's fine as is.

Build is green

Patch application report for D7226 (id=26195)

Rebasing onto 94f9aa2228...

Current branch diff-target is up to date.
Changes applied before test
commit 5a7d59cb2cc7ddb5bae9ac30f8a31beb78c8dd5d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Feb 22 18:41:45 2022 +0100

    deposit-list: Allow deposit listing with their raw metadata if any
    
    This now lists the deposit with their associated raw metadata if any is present. This
    will allow adaptations in the moderation view [1] to display the metadata provenance
    url (provided it's parsed out of the raw metadata).
    
    [1] The moderation view consumes this internal api.
    
    Related to T3677

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/736/ for more details.

This revision is now accepted and ready to land.Feb 23 2022, 11:21 AM