Paths

Table of Contentst

sourceforge: Fix origin URLs for CVS projects
ClosedPublic
Actions

Authored by anlambert on Feb 16 2022, 11:39 AM.

Details

Reviewers

stsp
ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3789: Adapt sourceforge lister to list cvs origins according to what the cvs loader expects

Commits

rDLS6a7479553e6b: sourceforge: Fix origin URLs for CVS projects

Summary

CVS projects are different from other VCS ones, they use the rsync
protocol, a list of modules needs to be fetched from an info page
and multiple origin URLs can be produced for a same project.

Related to T3789

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Feb 16 2022, 11:39 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 16 2022, 11:39 AM

Build is green

Patch application report for D7186 (id=26025)

Rebasing onto 31b4429ced...

Current branch diff-target is up to date.

Changes applied before test

commit d709a47e89a559d972b5145bb2af8eeaa2ad3c39
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Feb 15 22:16:45 2022 +0100

    sourceforge: Fix origin URLs for CVS projects
    
    CVS projects are different from other VCS ones, they use the rsync
    protocol, a list of modules needs to be fetched from an info page
    and multiple origin URLs can be produced for a same project.
    
    Related to T3789

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/452/ for more details.

Harbormaster completed remote builds in B26895: Diff 26025.Feb 16 2022, 11:42 AM

anlambert requested review of this revision.Feb 16 2022, 11:42 AM

LGTM

@stsp Any opinion on this?

lgtm

swh/lister/sourceforge/lister.py
371	bump that to an error level?

anlambert added inline comments.Feb 16 2022, 12:07 PM

swh/lister/sourceforge/lister.py
371	I can bump to `logger.warning` yes.

Bump log from debug to warning.

Build is green

Patch application report for D7186 (id=26028)

Rebasing onto 31b4429ced...

Current branch diff-target is up to date.

Changes applied before test

commit 7f18f6a65f8d70a3e027414be7c831ea2115612e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Feb 15 22:16:45 2022 +0100

    sourceforge: Fix origin URLs for CVS projects
    
    CVS projects are different from other VCS ones, they use the rsync
    protocol, a list of modules needs to be fetched from an info page
    and multiple origin URLs can be produced for a same project.
    
    Related to T3789

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/453/ for more details.

Harbormaster completed remote builds in B26897: Diff 26028.Feb 16 2022, 12:11 PM

Rebase

Build is green

Patch application report for D7186 (id=26088)

Rebasing onto 4265e5dd77...

Current branch diff-target is up to date.

Changes applied before test

commit 6a7479553e6be3a84790001c150bba39be44864d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Feb 15 22:16:45 2022 +0100

    sourceforge: Fix origin URLs for CVS projects
    
    CVS projects are different from other VCS ones, they use the rsync
    protocol, a list of modules needs to be fetched from an info page
    and multiple origin URLs can be produced for a same project.
    
    Related to T3789

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/462/ for more details.

Harbormaster completed remote builds in B26957: Diff 26088.Feb 17 2022, 1:54 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2022, 1:55 PM

Closed by commit rDLS6a7479553e6b: sourceforge: Fix origin URLs for CVS projects (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLS6a7479553e6b: sourceforge: Fix origin URLs for CVS projects.