rebase
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 1 2021
In D5780#147451, @vlorentz wrote:what about disabling E501 for the whole file, instead of repeating the comment? https://stackoverflow.com/a/64431741
rebase
In D5772#147476, @aeviso wrote:Not sure if I follow what the test is doing since it not clear to me what's the content of storage_and_CMDBTS,
May 28 2021
May 26 2021
In D5773#147221, @aeviso wrote:I'm not really sure this new algorithm does the same as the previous one. Some subtle things were changed and I have the filling the semantics are different now. Also, I found the previous version to be clearer, I rather stay with it
May 25 2021
rebase
rebase
rebase
rebase + also apply to add_child()
rebase
small improvement of a comment + type annotation for the local variable 'fdates'
May 21 2021
consider the minor fix in the README file, otherwise ok, thanks!
May 20 2021
May 19 2021
please also add a piece of documentation somewhere on this alt. "cassandra" backend config (aka. "how to use scylladb" or something).
May 18 2021
tests are green, so it should be ok I guess
May 17 2021
LGTM, any reason for not landing it?
May 11 2021
May 10 2021
May 7 2021
rebase
May 6 2021
rebase
Make the number of (single-object insertion) retries configurable
May 5 2021
rebased
remove dead code and improve a bit the commit message
May 4 2021
besides the type aliasing statements that I find a bit confusing, LGTM.
I'm not very fond of the name of all this (from_disk, HgLoaderFromDisk, etc.) since it makes people think it cannot deal with remote hg repos (which the HgLoaderFromDisk does, but this is not really advertized, as far as I can tell).
Answer (most) vlorentz comments/remark
rebase and improve logging messages
May 3 2021
In D5648#143320, @vlorentz wrote:What's the motivation?
Apr 29 2021
rebase
and MetadataXXX
rebase
and the origin_visit_status_add() specific implementation as well...
I'm not fond of the 'check_missing' name for the argument, but would prefer 'allow_overwrite'.