Page MenuHomeSoftware Heritage

Replace the 'dates' argument of IsochroneNode() by a simple 'date' one
ClosedPublic

Authored by douardda on May 25 2021, 10:15 AM.

Details

Summary

there is no need for passing a dict here, we only care about the date
for the node being instanciated.

Diff Detail

Repository
rDPROV Provenance database
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5771 (id=20636)

Rebasing onto b2ddef88eb...

Current branch diff-target is up to date.
Changes applied before test
commit 6ae8de468d94ab3398016add37747a13e43e8cac
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 11 15:33:57 2021 +0200

    Replace the 'dates' argument of IsochroneNode() by a simple 'date' one
    
    there is no need for passing a dict here, we only care about the date
    for the node being instanciated.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/22/ for more details.

This revision is now accepted and ready to land.May 25 2021, 10:17 AM

rebase + also apply to add_child()

Build is green

Patch application report for D5771 (id=20669)

Rebasing onto 77fce4e59d...

Current branch diff-target is up to date.
Changes applied before test
commit 113e11031aa5365a9244409a0cfe646061cb94f9
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 11 15:33:57 2021 +0200

    Replace the 'dates' argument of IsochroneNode() by a simple 'date' one
    
    there is no need for passing a dict here, we only care about the date
    for the node being instanciated.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/32/ for more details.