Replace the 'dates' argument of IsochroneNode() by a simple 'date' one
ClosedPublic
Actions

Authored by douardda on May 25 2021, 10:15 AM.

Details

Reviewers

vlorentz
aeviso

Group Reviewers

Reviewers

Commits

rDPROV113e11031aa5: Replace the 'dates' argument of IsochroneNode() by a simple 'date' one

Summary

there is no need for passing a dict here, we only care about the date
for the node being instanciated.

Diff Detail

Repository

rDPROV Provenance database

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.May 25 2021, 10:15 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 25 2021, 10:15 AM

douardda added a child revision: D5772: Add a test for the build_isochrone_graph() function.May 25 2021, 10:15 AM

Build is green

Patch application report for D5771 (id=20636)

Rebasing onto b2ddef88eb...

Current branch diff-target is up to date.

Changes applied before test

commit 6ae8de468d94ab3398016add37747a13e43e8cac
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 11 15:33:57 2021 +0200

    Replace the 'dates' argument of IsochroneNode() by a simple 'date' one
    
    there is no need for passing a dict here, we only care about the date
    for the node being instanciated.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/22/ for more details.

Harbormaster completed remote builds in B21600: Diff 20636.May 25 2021, 10:16 AM

douardda requested review of this revision.May 25 2021, 10:16 AM

vlorentz accepted this revision.May 25 2021, 10:17 AM

This revision is now accepted and ready to land.May 25 2021, 10:17 AM

rebase + also apply to add_child()

Build is green

Patch application report for D5771 (id=20669)

Rebasing onto 77fce4e59d...

Current branch diff-target is up to date.

Changes applied before test

commit 113e11031aa5365a9244409a0cfe646061cb94f9
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 11 15:33:57 2021 +0200

    Replace the 'dates' argument of IsochroneNode() by a simple 'date' one
    
    there is no need for passing a dict here, we only care about the date
    for the node being instanciated.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/32/ for more details.

Harbormaster completed remote builds in B21633: Diff 20669.May 25 2021, 4:36 PM

aeviso accepted this revision.May 26 2021, 12:01 PM

Closed by commit rDPROV113e11031aa5: Replace the 'dates' argument of IsochroneNode() by a simple 'date' one (authored by douardda). · Explain WhyJun 1 2021, 10:42 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDPROV113e11031aa5: Replace the 'dates' argument of IsochroneNode() by a simple 'date' one.

douardda removed a child revision: D5772: Add a test for the build_isochrone_graph() function.Jun 1 2021, 11:02 AM

douardda added a child revision: D5772: Add a test for the build_isochrone_graph() function.Jun 1 2021, 11:26 AM