Page MenuHomeSoftware Heritage
Differential D5769

client: Open a paginated list user deposits endpoint
ClosedPublic
Actions

Authored by ardumont on May 24 2021, 4:02 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2996: Add possibility to fetch a list of deposits on the deposit cli
Commits
rDDEP104a4e379941: client: Open a paginated list user deposits endpoint
Summary

Next step is to actually open the cli endpoint which will use this to allow deposit
listing [1].

[1] D5770

Related to T2996

Test Plan

tox

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.May 24 2021, 4:02 PM
swh-public-ci added a comment.May 24 2021, 4:06 PM

Build is green

Patch application report for D5769 (id=20631)

Rebasing onto 63c1bc3e0d...

Current branch diff-target is up to date.
Changes applied before test
commit 772df89c40fbc1c949a8fac4d08ae333ae18a7dd
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 24 15:55:05 2021 +0200

    client: Open a paginated list user deposits endpoint
    
    Related to T2996

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/656/ for more details.

Harbormaster completed remote builds in B21595: Diff 20631.May 24 2021, 4:06 PM
ardumont requested review of this revision.May 24 2021, 4:06 PM
ardumont updated this revision to Diff 20632.May 24 2021, 4:20 PM

Check also the main public api client class

swh-public-ci added a comment.May 24 2021, 4:23 PM

Build is green

Patch application report for D5769 (id=20632)

Rebasing onto 63c1bc3e0d...

Current branch diff-target is up to date.
Changes applied before test
commit 82a8482c9faace59de4976a11aa0c2b79b3a4998
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 24 15:55:05 2021 +0200

    client: Open a paginated list user deposits endpoint
    
    Related to T2996

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/657/ for more details.

Harbormaster completed remote builds in B21596: Diff 20632.May 24 2021, 4:23 PM
ardumont updated this revision to Diff 20633.May 24 2021, 4:32 PM
  • Drop unneeded comment
  • Make the dict reading instructions more resilient for edge cases
swh-public-ci added a comment.May 24 2021, 4:36 PM

Build is green

Patch application report for D5769 (id=20633)

Rebasing onto 63c1bc3e0d...

Current branch diff-target is up to date.
Changes applied before test
commit fdae25cdd6d9673424c2bc3ea2b6b057c10856b9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 24 15:55:05 2021 +0200

    client: Open a paginated list user deposits endpoint
    
    Related to T2996

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/658/ for more details.

Harbormaster completed remote builds in B21597: Diff 20633.May 24 2021, 4:36 PM
ardumont added a child revision: D5770: Open `swh deposit list` cli to allow user to list their deposits.May 24 2021, 5:26 PM
douardda added a subscriber: douardda.May 25 2021, 10:32 AM
douardda added inline comments.
swh/deposit/client.py
277–279

I'm always nervous seeing a mutable structure used as default value of a method/function... Canot it be a headers: Option[Dict} = None instead?

ardumont added inline comments.May 25 2021, 10:38 AM
swh/deposit/client.py
277–279

Sure.

ardumont edited the summary of this revision. (Show Details)May 25 2021, 10:41 AM
ardumont updated this revision to Diff 20640.May 25 2021, 10:51 AM
ardumont edited the summary of this revision. (Show Details)

Adapt according to suggestion

swh-public-ci added a comment.May 25 2021, 10:55 AM

Build is green

Patch application report for D5769 (id=20640)

Rebasing onto 63c1bc3e0d...

Current branch diff-target is up to date.
Changes applied before test
commit 2813abc24c34326709899276c8bae0077083e680
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 24 15:55:05 2021 +0200

    client: Open a paginated list user deposits endpoint
    
    Related to T2996

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/661/ for more details.

Harbormaster completed remote builds in B21604: Diff 20640.May 25 2021, 10:55 AM
ardumont updated this revision to Diff 20642.May 25 2021, 10:56 AM

Fix docstring typos

swh-public-ci added a comment.May 25 2021, 11:03 AM

Build is green

Patch application report for D5769 (id=20642)

Rebasing onto 63c1bc3e0d...

Current branch diff-target is up to date.
Changes applied before test
commit 88f4ffd13ed4f38a12ff3684f52a09a5d79a19f0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 24 15:55:05 2021 +0200

    client: Open a paginated list user deposits endpoint
    
    Related to T2996

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/663/ for more details.

Harbormaster completed remote builds in B21606: Diff 20642.May 25 2021, 11:03 AM
vlorentz added a subscriber: vlorentz.May 25 2021, 2:26 PM

I'd like to make a few changes to the endpoint first, that will require changing this diff, so I'll review this later if you don't mind

ardumont added a comment.May 25 2021, 2:41 PM
In D5769#146996, @vlorentz wrote:

I'd like to make a few changes to the endpoint first, that will require changing this diff, so I'll review this later if you don't mind

Sure. I guess it's [1] or is there more to it?

[1] D5778

ardumont planned changes to this revision.May 25 2021, 2:42 PM
vlorentz added a comment.May 25 2021, 2:48 PM

and D5779

ardumont updated this revision to Diff 20659.May 25 2021, 3:23 PM

Rebase and adapt according to latest work on the server side implementation

swh-public-ci added a comment.May 25 2021, 3:28 PM

Build is green

Patch application report for D5769 (id=20659)

Rebasing onto 77c229331e...

Current branch diff-target is up to date.
Changes applied before test
commit 104a4e379941b1e95a06e986bd3ca49b4c6cd429
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 24 15:55:05 2021 +0200

    client: Open a paginated list user deposits endpoint
    
    Related to T2996

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/667/ for more details.

Harbormaster completed remote builds in B21623: Diff 20659.May 25 2021, 3:28 PM
vlorentz accepted this revision.May 25 2021, 3:32 PM
vlorentz added inline comments.
swh/deposit/client.py
494

ugh... I hate xmltodict...

This revision is now accepted and ready to land.May 25 2021, 3:32 PM
Closed by commit rDDEP104a4e379941: client: Open a paginated list user deposits endpoint (authored by ardumont). · Explain WhyMay 25 2021, 3:38 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDDEP104a4e379941: client: Open a paginated list user deposits endpoint.

Revision Contents
Changeset List

PathSize
swh/
deposit/
121 lines
tests/
data/
atom/
18 lines
16 lines
28 lines
119 lines
13 lines

Diff 20665

View Options

swh/deposit/client.py

Loading...
View Options

swh/deposit/tests/data/atom/entry-list-deposits-page1.xml

Loading...
View Options

swh/deposit/tests/data/atom/entry-list-deposits-page2.xml

Loading...
View Options

swh/deposit/tests/data/atom/entry-list-deposits.xml

Loading...
View Options

swh/deposit/tests/test_client_module.py

Loading...
View Options

swh/deposit/utils.py

Loading...
About · Developer information · Legal