• typing: minimal changes to make a no-op mypy run pass
• init.py: switch to documented way of extending path
• tox: anticipate mypy run to just after flake8

• typing: minimal changes to make a no-op mypy run pass
• init.py: switch to documented way of extending path
• mypy: ignore swh.journal to work-around dependency loop
• storage.py: ignore typing of optional get_journal_writer import
• mypy.ini: be less flaky w.r.t. the packages installed in tox
• tox: anticipate mypy run to just after flake8

How about landing it as explicitly skipped by pytest though?

looks great ! I've only noticed minor stuff (this time for real ;-))

• tox: anticipate mypy run to just after flake8

• mypy.ini: be less flaky w.r.t. the packages installed in tox

• typing: minimal changes to make a no-op mypy run pass
• init.py: switch to documented way of extending path
• mypy: ignore swh.journal to work-around dependency loop
• storage.py: ignore typing of optional get_journal_writer import

Nice work!

• mypy: ignore swh.journal to work-around dependency loop

it worked, but the diff didn't auto close upon git push of 2e3efced7acda68e91518dd02343e14025fe306c
uhm…

• init.py: switch to documented way of extending path

• init.py: switch to documented way of extending path

• init.py: switch to documented way of extending path

this is now (also) waiting for an upstream release of django-stubs compatible with mypy >= 0.730

• typing: minimal changes to make a no-op mypy run pass
• typing: convert leftover variable annotation to comments
• init.py: switch to documented way of extending path

In T2008#37369, @anlambert wrote:

Almost all points have been treated and deployed to production (see https://www.softwareheritage.org/).

In T2008#37352, @anlambert wrote:

I have deployed a new version of https://archive.softwareheritage.org including the archive evolution graphs on the homepage.

• typing: convert leftover variable annotation to comments

• models: add required on_delete kwarg to ForeignKey
• models: add migration to on_delete=protect
• typing: minimal changes to make a no-op mypy run pass

• models: add migration to on_delete=protect

In D2031#47035, @ardumont wrote:

Also, when modifying the models, you need to call a routine which generates the migration scripts (corresponding to the change you made in the model).

• tox.ini: add mypy section

merged two unrelated diffs, will resubmit

• typing: minimal changes to make a no-op mypy run pass

diff updated, addressing comments

• MockBlockBlobService: make data a protected _data attribute

as discussed f2f, we'll drop the backward compatibility layer as to break the import loop

note that there is a dependency loop between this diff and D2023, because we do have an import loop between swh-storage and swh-journal (even after D1993)

note that there is a dependency loop between this diff and D2024, because we do have an import loop between swh-storage and swh-journal (even after D1993)

• typing: convert a swh.objstorage variable annotation to comment style