Differential D2036

init.py: switch to documented way of extending path
ClosedPublic
Actions

Authored by zack on Sep 27 2019, 9:10 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCORE7a7d06a067bb: init.py: switch to documented way of extending path

Summary

make mypy 0.730 pass cleanly again

In addition to make mypy pass again, this is also the documented way of using
extend_path, so it's better/nicer to switch to it anyway.

Once this is accepted for this module, I will batch apply this change to all
other __init__.py around.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Sep 27 2019, 9:10 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 27 2019, 9:10 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/295/ for more details.

Harbormaster completed remote builds in B7951: Diff 6832.Sep 27 2019, 9:13 AM

Clearer.

This revision is now accepted and ready to land.Sep 27 2019, 9:43 AM

Out of curiosity, I checked the docso might as well provide the link [1]

[1] https://docs.python.org/3.5/library/pkgutil.html

Closed by commit rDCORE7a7d06a067bb: init.py: switch to documented way of extending path (authored by zack). · Explain WhySep 27 2019, 10:16 AM

This revision was automatically updated to reflect the committed changes.

zack added a commit: rDCORE7a7d06a067bb: init.py: switch to documented way of extending path.

Revision Contents
Changeset List

Path

Size

swh/

__init__.py

4 lines

Diff 6833

View Options

init.py: switch to documented way of extending pathClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6833

swh/__init__.py

init.py: switch to documented way of extending path
ClosedPublic
Actions

Revision Contents
Changeset List

swh/init.py