Page MenuHomeSoftware Heritage
Differential D2024

typing: minimal changes to make a no-op mypy run pass
ClosedPublic
Actions

Authored by zack on Sep 22 2019, 4:47 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDJNL045b142a3446: tox: anticipate mypy run to just after flake8
rDJNLdec930105642: init.py: switch to documented way of extending path
rDJNLd541a5562118: typing: minimal changes to make a no-op mypy run pass
Test Plan

tox -e mypy

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Sep 22 2019, 4:47 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 22 2019, 4:47 PM
zack mentioned this in D2023: typing: minimal changes to make a no-op mypy run pass.Sep 22 2019, 4:50 PM
zack added a child revision: D2023: typing: minimal changes to make a no-op mypy run pass.
swh-public-ci added a comment.Sep 22 2019, 4:51 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/269/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/269/console

Harbormaster failed remote builds in B7912: Diff 6798!Sep 22 2019, 4:51 PM
zack added a comment.Sep 22 2019, 4:51 PM

note that there is a dependency loop between this diff and D2023, because we do have an import loop between swh-storage and swh-journal (even after D1993)

the dependency between this diff and D2023 is not declared here, because phabricator prevents loops

vlorentz accepted this revision.Sep 23 2019, 12:31 PM
This revision is now accepted and ready to land.Sep 23 2019, 12:31 PM
zack removed a child revision: D2023: typing: minimal changes to make a no-op mypy run pass.Sep 24 2019, 1:27 PM
zack added a parent revision: D2023: typing: minimal changes to make a no-op mypy run pass.
zack updated this revision to Diff 6836.Sep 27 2019, 10:37 AM
  • init.py: switch to documented way of extending path
Harbormaster failed remote builds in B7958: Diff 6836!Sep 27 2019, 10:42 AM
swh-public-ci added a comment.Sep 27 2019, 10:42 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/274/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/274/console

zack updated this revision to Diff 6881.Oct 1 2019, 9:01 AM
  • typing: minimal changes to make a no-op mypy run pass
  • init.py: switch to documented way of extending path
  • tox: anticipate mypy run to just after flake8
swh-public-ci added a comment.Oct 1 2019, 9:05 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/275/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/275/console

Harbormaster failed remote builds in B8023: Diff 6881!Oct 1 2019, 9:05 AM
swh-public-ci added a comment.Oct 1 2019, 10:18 AM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/276/ for more details.

Harbormaster completed remote builds in B8023: Diff 6881.Oct 1 2019, 10:18 AM
Closed by commit rDJNLd541a5562118: typing: minimal changes to make a no-op mypy run pass (authored by zack). · Explain WhyOct 1 2019, 10:18 AM
This revision was automatically updated to reflect the committed changes.
zack added a commit: rDJNLd541a5562118: typing: minimal changes to make a no-op mypy run pass.
zack added a commit: rDJNLdec930105642: init.py: switch to documented way of extending path.
zack added a commit: rDJNL045b142a3446: tox: anticipate mypy run to just after flake8.

Revision Contents
Changeset List

PathSize
1 line
1 line
21 lines
swh/
5 lines
journal/
1 line
tests/
4 lines
4 lines
10 lines

Diff 6887

View Options

.gitignore

Loading...
View Options

MANIFEST.in

Loading...
View Options

mypy.ini

Loading...
View Options

swh/__init__.py

Loading...
View Options

swh/journal/py.typed

Loading...
View Options

swh/journal/tests/conftest.py

Loading...
View Options

swh/journal/tests/test_cli.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal