Page MenuHomeSoftware Heritage

typing: minimal changes to make a no-op mypy run pass
ClosedPublic

Authored by zack on Sun, Sep 22, 4:47 PM.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Sun, Sep 22, 4:47 PM
zack added a comment.Sun, Sep 22, 4:51 PM

note that there is a dependency loop between this diff and D2023, because we do have an import loop between swh-storage and swh-journal (even after D1993)

the dependency between this diff and D2023 is not declared here, because phabricator prevents loops

vlorentz accepted this revision.Mon, Sep 23, 12:31 PM
This revision is now accepted and ready to land.Mon, Sep 23, 12:31 PM
zack updated this revision to Diff 6836.Fri, Sep 27, 10:37 AM
  • init.py: switch to documented way of extending path
zack updated this revision to Diff 6881.Tue, Oct 1, 9:01 AM
  • typing: minimal changes to make a no-op mypy run pass
  • init.py: switch to documented way of extending path
  • tox: anticipate mypy run to just after flake8