Page MenuHomeSoftware Heritage
Feed Advanced Search

Nov 24 2022

anlambert requested review of D8882: replay: Do not ignore externals in copyfrom operations.
Nov 24 2022, 11:59 AM
anlambert accepted D8874: Dockerfile: Reference the rsvndump binary in /usr/local/bin/rsvndump.
Nov 24 2022, 11:53 AM
anlambert accepted D8876: Dockerfile: Reference the rsvndump binary in /usr/local/bin/rsvndump.
Nov 24 2022, 11:52 AM
anlambert closed D8879: svn: Also escape hash signs in URLs to avoid libsvn assertion.
Nov 24 2022, 11:38 AM
anlambert committed rDLDSVNbcd1e753c60b: svn: Also escape hash signs in URLs to avoid libsvn assertion (authored by anlambert).
svn: Also escape hash signs in URLs to avoid libsvn assertion
Nov 24 2022, 11:38 AM
anlambert requested changes to D8881: Document the need for higher vm.max_map_count.
Nov 24 2022, 11:35 AM
anlambert accepted D8880: Fix crash on null Release message.
Nov 24 2022, 11:34 AM
anlambert added a comment to D8878: vault/assets: Fix cooking task creation when there is a pending one.

thanks!

Is it visible on the Downloads page even if someone else requested the cooking?

Nov 24 2022, 10:40 AM
anlambert added a comment to D8879: svn: Also escape hash signs in URLs to avoid libsvn assertion.

Why not urlencode? Couldn't this be an issue with other characters?

Nov 24 2022, 10:39 AM

Nov 23 2022

anlambert requested review of D8879: svn: Also escape hash signs in URLs to avoid libsvn assertion.
Nov 23 2022, 5:09 PM
anlambert added a comment to T4698: Error when requesting vault cooking for a directory in pending state.

Nice catch, fixed in D8878.

Nov 23 2022, 5:06 PM · Web app
anlambert requested review of D8878: vault/assets: Fix cooking task creation when there is a pending one.
Nov 23 2022, 5:06 PM
anlambert closed D8872: loader: Add logs displaying path differences after revision replay.
Nov 23 2022, 4:55 PM
anlambert committed rDLDSVNa843858b0c2f: loader: Add logs displaying path differences after revision replay (authored by anlambert).
loader: Add logs displaying path differences after revision replay
Nov 23 2022, 4:55 PM
anlambert added a revision to T4698: Error when requesting vault cooking for a directory in pending state: D8878: vault/assets: Fix cooking task creation when there is a pending one.
Nov 23 2022, 4:50 PM · Web app
anlambert retitled D8875: cypress/origin-save: Fix flaky test from package.json: Bump cypress to 11.2.0 to cypress/origin-save: Fix flaky test.
Nov 23 2022, 4:37 PM
anlambert updated the diff for D8875: cypress/origin-save: Fix flaky test.

Remove cypress upgrade, the hanging bug appeared again after a couple of job executions (sigh)

Nov 23 2022, 4:24 PM
anlambert updated the diff for D8875: cypress/origin-save: Fix flaky test.

Trigger new build

Nov 23 2022, 4:14 PM
anlambert updated the diff for D8875: cypress/origin-save: Fix flaky test.

Add commit fixing a flaky cypress test

Nov 23 2022, 3:09 PM
anlambert updated the diff for D8875: cypress/origin-save: Fix flaky test.

Update commit message

Nov 23 2022, 2:45 PM
anlambert requested review of D8875: cypress/origin-save: Fix flaky test.
Nov 23 2022, 2:32 PM
anlambert added inline comments to D8872: loader: Add logs displaying path differences after revision replay.
Nov 23 2022, 11:42 AM
anlambert added inline comments to D8872: loader: Add logs displaying path differences after revision replay.
Nov 23 2022, 10:45 AM

Nov 22 2022

anlambert requested review of D8872: loader: Add logs displaying path differences after revision replay.
Nov 22 2022, 5:43 PM
anlambert committed rDWAPPSb04d5848c6d8: cypress: Increase sqlite3 busy timeout (authored by anlambert).
cypress: Increase sqlite3 busy timeout
Nov 22 2022, 5:12 PM
anlambert closed D8869: cypress: Increase sqlite3 busy timeout.
Nov 22 2022, 5:12 PM
anlambert committed rDWAPPS8a35c0b688af: package.json: Revert cypress upgrade to 11.x again (authored by anlambert).
package.json: Revert cypress upgrade to 11.x again
Nov 22 2022, 5:12 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Final update:

  • package.json: Revert cypress upgrade to 11.x again
  • cypress: Increase sqlite3 busy timeout
Nov 22 2022, 5:03 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Update

Nov 22 2022, 4:54 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Update

Nov 22 2022, 4:47 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Try to enable electron and chromium logging

Nov 22 2022, 4:32 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Update

Nov 22 2022, 4:27 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Try to disable GPU use with electron

Nov 22 2022, 4:22 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Update

Nov 22 2022, 4:01 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Remove use of custom docker image

Nov 22 2022, 3:48 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Try to use chromium to run cypress tests

Nov 22 2022, 3:31 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Cypress tests still hanging, trying another base docker image

Nov 22 2022, 3:24 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Update

Nov 22 2022, 3:16 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Update

Nov 22 2022, 3:07 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Update

Nov 22 2022, 2:51 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Update

Nov 22 2022, 2:47 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Add libpq-dev and libcmph-dev to docker image

Nov 22 2022, 2:36 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Update

Nov 22 2022, 2:30 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Upgrade pip in docker image

Nov 22 2022, 2:28 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Add postgres to docker image

Nov 22 2022, 2:24 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Add git in docker image

Nov 22 2022, 2:19 PM
anlambert updated the diff for D8869: cypress: Increase sqlite3 busy timeout.

Experiment with other docker image for running cypress tests

Nov 22 2022, 2:16 PM
anlambert requested review of D8869: cypress: Increase sqlite3 busy timeout.
Nov 22 2022, 11:52 AM
anlambert committed rDWAPPS264dd3f5a42b: api/apidoc: Ensure to not create link for endpoint URL description (authored by anlambert).
api/apidoc: Ensure to not create link for endpoint URL description
Nov 22 2022, 11:00 AM
anlambert closed D8868: save_origin_webhooks: Handle private repositories.
Nov 22 2022, 10:40 AM
anlambert committed rDWAPPS1b8992d585a0: save_origin_webhooks: Handle private repositories (authored by anlambert).
save_origin_webhooks: Handle private repositories
Nov 22 2022, 10:40 AM
anlambert closed D8867: save_origin_webhooks: Handle github ping event.
Nov 22 2022, 10:40 AM
anlambert committed rDWAPPS84922dfd698b: save_origin_webhooks: Handle github ping event (authored by anlambert).
save_origin_webhooks: Handle github ping event
Nov 22 2022, 10:39 AM

Nov 21 2022

anlambert requested review of D8868: save_origin_webhooks: Handle private repositories.
Nov 21 2022, 5:49 PM
anlambert added a revision to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook: D8868: save_origin_webhooks: Handle private repositories.
Nov 21 2022, 5:40 PM · Web app
anlambert requested review of D8867: save_origin_webhooks: Handle github ping event.
Nov 21 2022, 5:28 PM
anlambert added a revision to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook: D8867: save_origin_webhooks: Handle github ping event.
Nov 21 2022, 4:46 PM · Web app
anlambert committed rDWAPPS01e50d60cd84: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Nov 21 2022, 4:37 PM
anlambert committed rCJSWHd1dd97891b0c: templates/stage-cypress-tests: Simplify job implementation (authored by anlambert).
templates/stage-cypress-tests: Simplify job implementation
Nov 21 2022, 4:36 PM
anlambert closed D8848: fedora: Update versions in packages dict provided as loader argument.
Nov 21 2022, 2:58 PM
anlambert committed rDLSf4aafe026b29: fedora: Update versions in packages dict provided as loader argument (authored by anlambert).
fedora: Update versions in packages dict provided as loader argument
Nov 21 2022, 2:58 PM
anlambert updated the diff for D8848: fedora: Update versions in packages dict provided as loader argument.

Rebase and remove unused fields in dicts sent to rpm loader.

Nov 21 2022, 2:15 PM
anlambert added inline comments to D8848: fedora: Update versions in packages dict provided as loader argument.
Nov 21 2022, 1:57 PM
anlambert closed T4190: Generated incorrect webpack-stats.json path as Invalid.
Nov 21 2022, 11:43 AM · Web app
anlambert closed T4384: add forge now - rename "denied" status as Resolved.
Nov 21 2022, 11:43 AM · Web app, Add Forge Now
anlambert closed T4686: Duplicated branch names are rendered by the webapp as Resolved.

Fixed and deployed.

Nov 21 2022, 11:42 AM · Web app
anlambert accepted D8379: Hackage: Loads Hackage Listed origins.

@anlambert hi, can we merge this one?

Nov 21 2022, 11:40 AM

Nov 17 2022

anlambert closed D8855: Makefile: Speedup sphinx-apidoc execution significantly.
Nov 17 2022, 9:12 PM
anlambert committed rDDOC2f5cbf0cea45: Makefile: Speedup sphinx-apidoc execution significantly (authored by anlambert).
Makefile: Speedup sphinx-apidoc execution significantly
Nov 17 2022, 9:12 PM
anlambert requested review of D8855: Makefile: Speedup sphinx-apidoc execution significantly.
Nov 17 2022, 7:33 PM

Nov 16 2022

anlambert committed rDWAPPS44dfeee1b591: package.json: Revert cypress upgrade to 11.x (authored by anlambert).
package.json: Revert cypress upgrade to 11.x
Nov 16 2022, 5:14 PM
anlambert committed rDWAPPSfc5bf62ea1c3: package.json: Upgrade depdendencies (authored by anlambert).
package.json: Upgrade depdendencies
Nov 16 2022, 3:57 PM
anlambert closed D8837: api: Improve HTML documentation.
Nov 16 2022, 3:57 PM
anlambert committed rDWAPPS13ac1fd97a7e: api: Improve HTML documentation (authored by anlambert).
api: Improve HTML documentation
Nov 16 2022, 3:57 PM
anlambert updated the diff for D8837: api: Improve HTML documentation.

Rebase

Nov 16 2022, 3:30 PM
anlambert closed D8841: save_code_now: Allow request creation if previous for origin is running.
Nov 16 2022, 3:29 PM
anlambert committed rDWAPPSab849109ea1d: save_code_now: Allow request creation if previous for origin is running (authored by anlambert).
save_code_now: Allow request creation if previous for origin is running
Nov 16 2022, 3:29 PM
anlambert updated the diff for D8841: save_code_now: Allow request creation if previous for origin is running.

Rebase

Nov 16 2022, 3:15 PM
anlambert accepted D8753: feat: Introduce RPM loader.

Looks good to me, thanks !

Nov 16 2022, 2:18 PM
anlambert requested changes to D8753: feat: Introduce RPM loader.

@KShivendu , before landing this please fix the year in some license headers and update tests to match fedora lister output.

Nov 16 2022, 10:56 AM

Nov 15 2022

anlambert added inline comments to D8753: feat: Introduce RPM loader.
Nov 15 2022, 5:41 PM
anlambert requested changes to D8753: feat: Introduce RPM loader.

@KShivendu , we are almost in a landable state for the RPM loader.

Nov 15 2022, 5:34 PM
anlambert requested review of D8848: fedora: Update versions in packages dict provided as loader argument.
Nov 15 2022, 5:17 PM
anlambert added a revision to T4448: Implementation of Fedora Lister: D8848: fedora: Update versions in packages dict provided as loader argument.
Nov 15 2022, 5:11 PM · RPM lister, Archive coverage
anlambert closed D8847: browse: Display branches names in snapshot releases view.
Nov 15 2022, 4:50 PM
anlambert committed rDWAPPS694802b2ac85: browse: Display branches names in snapshot releases view (authored by anlambert).
browse: Display branches names in snapshot releases view
Nov 15 2022, 4:50 PM
anlambert updated the diff for D8847: browse: Display branches names in snapshot releases view.

Update commit message

Nov 15 2022, 1:58 PM
anlambert retitled D8847: browse: Display branches names in snapshot releases view from browse: Display branch name in snapshot releases view to browse: Display branches names in snapshot releases view.
Nov 15 2022, 1:57 PM
anlambert requested review of D8847: browse: Display branches names in snapshot releases view.
Nov 15 2022, 1:54 PM
anlambert added a revision to T4686: Duplicated branch names are rendered by the webapp: D8847: browse: Display branches names in snapshot releases view.
Nov 15 2022, 1:44 PM · Web app
anlambert accepted D8846: Remove obsolete test setup command from developper documentation.
Nov 15 2022, 12:32 PM
anlambert closed D8840: maven: Add support for md5 checkums to check download integrity.
Nov 15 2022, 11:48 AM
anlambert committed rDLDBASE301502cbf8dc: maven: Add support for md5 checkums to check download integrity (authored by anlambert).
maven: Add support for md5 checkums to check download integrity
Nov 15 2022, 11:48 AM
anlambert closed D8839: maven: Simplify tests with requests_mock_datadir fixture.
Nov 15 2022, 11:48 AM
anlambert committed rDLDBASE5778cfce008a: maven: Simplify tests with requests_mock_datadir fixture (authored by anlambert).
maven: Simplify tests with requests_mock_datadir fixture
Nov 15 2022, 11:48 AM
anlambert added a comment to T4686: Duplicated branch names are rendered by the webapp.

The issue comes from the fact that the webapp gets the release names from the release objects of our data model and not
from the branch names targeting releases in associated snapshot object.

Nov 15 2022, 11:34 AM · Web app
anlambert renamed T4686: Duplicated branch names are rendered by the webapp from Duplicate branch names rendered by the web app to Duplicated branch names are rendered by the webapp.
Nov 15 2022, 11:22 AM · Web app
anlambert added a comment to D8386: feat(fedora): Introduce fedora lister.
In D8386#229912, @olasd wrote:
In D8386#229882, @olasd wrote:

@anlambert

I noticed that https://archive.softwareheritage.org/browse/origin/directory/?origin_url=deb://Ubuntu/packages/nginx has duplicate branch names, which is very confusing. In fact, even the default branch is repeated twice and I see two check marks. If we use branch names like 0.3.9-15.fc26, won't the same happen with Fedora listers? It doesn't seem to differentiate between the editions. (or does it?)

This seems like a misfeature in the webapp:

https://archive.softwareheritage.org/api/1/snapshot/158a3f36b0bd3da461fb7458de44cfa2c94e4270/

The snapshot has multiple branches, with the same version suffix, pointing at the same objects (because the exact same version of the package is present in multiple Ubuntu suites).

I'm not 100% sure how we should be fixing that, but that bug shouldn't prevent you from giving the fedora snapshots the "semantically correct" structure.

I also noticed that yesterday evening and I was also wondering what is the best way to fix that. I see two possible options:

  1. We change the names of the keys in snapshot branches dictionary in order to use the intrinsic version of a debian package instead of its extrinsic one (meaning releases/bionic-security/main/1.14.0-0ubuntu1.10 should rather be releases/1.14.0-0ubuntu1.10)
  2. We update the webapp to filter duplicated releases before display as the release name is used instead of the snapshot branches key associated to the release

I would rather go for the second one as keeping the debian/ubuntu suites and components in keys of snapshot branches dictionary seems of interest.
We could do the same for the fedora case as based on my tests it is quite common that extrinsic versions in the form [0-9].[0-9].[0-9]-[0-9].fc[0-9]+
target the same intrinsic version [0-9].[0-9].[0-9]-[0-9].

We should move this branch (ha) of discussion to a separate task. I would really want us to keep (and display) the information about what suites have been detected to contain what package.

How does the webapp get the release name showed in the menu? From the release object, or from the branch name?

I think it would make sense to display the branch name after the release name, if it didn't match the usual refs/tags/$(release name) pattern

Nov 15 2022, 11:20 AM
anlambert accepted D8844: origin-search: Only request 'url' field.

Nice catch !

Nov 15 2022, 11:02 AM
anlambert accepted D8386: feat(fedora): Introduce fedora lister.

Looks good to me, thanks !

Nov 15 2022, 10:59 AM