Page MenuHomeSoftware Heritage

save_code_now: Allow request creation if previous for origin is running
ClosedPublic

Authored by anlambert on Mon, Nov 14, 5:27 PM.

Details

Summary

Previously, the save code now service was not allowing to create a new
request for an origin if a previously created one for the same origin
was currently running.

However, new commits might have been pushed to the origin while a loading
task is running so this restriction does not make sense, especially for
the new forge webhook receivers feature.

Related to T4548

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8841 (id=31856)

Rebasing onto ad8558c69d...

Current branch diff-target is up to date.
Changes applied before test
commit de0d5cfdea3d52f60ac60ab6f6434a72c7f3881c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Nov 14 17:21:26 2022 +0100

    save_code_now: Allow request creation if previous for origin is running
    
    Previously, the save code now service was not allowing to create a new
    request for an origin if a previously created one for the same origin
    was currently running.
    
    However, new commits might have been pushed to the origin while a loading
    task is running so this restriction does not make sense, especially for
    the new forge webhook receivers feature.
    
    Related to T4548

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2131/ for more details.

This revision is now accepted and ready to land.Wed, Nov 16, 2:56 PM

Build is green

Patch application report for D8841 (id=31900)

Rebasing onto 694802b2ac...

Current branch diff-target is up to date.
Changes applied before test
commit ab849109ea1dac70d597316f3183e91742e6cb6c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Nov 14 17:21:26 2022 +0100

    save_code_now: Allow request creation if previous for origin is running
    
    Previously, the save code now service was not allowing to create a new
    request for an origin if a previously created one for the same origin
    was currently running.
    
    However, new commits might have been pushed to the origin while a loading
    task is running so this restriction does not make sense, especially for
    the new forge webhook receivers feature.
    
    Related to T4548

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2139/ for more details.