In D8759#227732, @vlorentz wrote:Hi, thanks for the diffs
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Oct 26 2022
Oct 26 2022
vlorentz triaged T4659: Fix all crashes of the git loader caused by malformed git objects as Normal priority.
Oct 25 2022
Oct 25 2022
olasd added a comment to T4644: replayer crashes on invalid directory entry name (b'gitter/gitter.xml').
This is now done, the objects are fixed in the production DB and kafka.
olasd added a comment to T4644: replayer crashes on invalid directory entry name (b'gitter/gitter.xml').
@vlorentz I'm running the following adaptation to your script:
Last analysis without [1]. That last diff should fix the key entries marked with the key 'only-version-should-be-tarball'.
ardumont committed rDSNIP4ff0739b5cae: nixguix/analyze-result: Improve extension grouping (authored by ardumont).
nixguix/analyze-result: Improve extension grouping
ardumont committed rDSNIP5203c59a2bb3: nixguix/analyze-result: Improve command output (authored by ardumont).
nixguix/analyze-result: Improve command output
ardumont added a comment to D8773: nixguix: Deal with edge case url with version instead of extension.
I think detecting versions is a lost cause. Here is what I had to do for PyPI:
https://forge.softwareheritage.org/source/swh-storage/browse/master/swh/storage/migrate_extrinsic_metadata.py$234-281
swh-public-ci added a comment to D8774: nixguix: Use content-disposition from http head request if provided.
Build is green
vlorentz added a comment to D8773: nixguix: Deal with edge case url with version instead of extension.
In D8773#228150, @vlorentz wrote:plus, Nix and Guix already have the package name and version in their metadata, can't we ask them to provide this data to us?
swh-public-ci added a comment to D8773: nixguix: Deal with edge case url with version instead of extension.
Build is green
vlorentz added a comment to D8773: nixguix: Deal with edge case url with version instead of extension.
plus, Nix and Guix already have the package name and version in their metadata, can't we ask them to provide this data to us?
Yeah, I think that makes sense. Time for these tests to be written? :)
vlorentz added a comment to D8773: nixguix: Deal with edge case url with version instead of extension.
I think detecting versions is a lost cause. Here is what I had to do for PyPI: https://forge.softwareheritage.org/source/swh-storage/browse/master/swh/storage/migrate_extrinsic_metadata.py$234-281
ardumont updated the diff for D8774: nixguix: Use content-disposition from http head request if provided.
Rebase
ardumont updated the diff for D8773: nixguix: Deal with edge case url with version instead of extension.
Improve the regexp version detection to be more restrictive.
must... resist... painting the bikeshed (git_manifest? git_object? raw_object?)
seirl added a comment to T4644: replayer crashes on invalid directory entry name (b'gitter/gitter.xml').
Oh yeah, I was thinking of just removing the entire project, but your solution also works.
Great, thanks!
vlorentz updated subscribers of T4644: replayer crashes on invalid directory entry name (b'gitter/gitter.xml').
seirl added a comment to T4644: replayer crashes on invalid directory entry name (b'gitter/gitter.xml').
Do you actually want to keep these objects? This would be inconsistent with the fixed loader behavior that would just reject those objects, and not load the repository at all.
ardumont added inline comments to D8773: nixguix: Deal with edge case url with version instead of extension.
ardumont added inline comments to D8773: nixguix: Deal with edge case url with version instead of extension.
anlambert added a comment to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook.
This is the POST request I received from SourceForge when pushing commit to a sample hg repository.
vlorentz changed the visibility for T4644: replayer crashes on invalid directory entry name (b'gitter/gitter.xml').
anlambert added a comment to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook.
This is the POST request I received from SourceForge when adding commit to a sample svn repository.
ardumont requested review of D8774: nixguix: Use content-disposition from http head request if provided.
anlambert added a comment to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook.
This is the POST request I received from SourceForge when pushing commit to a sample git repository.
vlorentz updated subscribers of T4644: replayer crashes on invalid directory entry name (b'gitter/gitter.xml').
I tried to add a workaround in the backfiller, but it is incredibly hard to do properly, especially as entries as disordered, so raw_manifest needs to be fixed in two different ways.
anlambert added a comment to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook.
This is the POST request I received from Gitea when pushing commit to a sample repository.
ardumont requested review of D8773: nixguix: Deal with edge case url with version instead of extension.
anlambert added a comment to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook.
This is the POST request I received from GitLab when pushing commit to a sample repository.
anlambert added a comment to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook.
I used ngrok to forward webhook requests to my local machine.
olasd committed rDSCHff75e742ee45: Ensure origins are not visited faster than twice a day (authored by olasd).
Ensure origins are not visited faster than twice a day
olasd committed rDSCH1f9109fa4d66: Refresh task type data from the database every time recurrent tasks are run (authored by olasd).
Refresh task type data from the database every time recurrent tasks are run
Use json instead of msgpack for serializers
Build is green
swh-public-ci added a comment to D8769: Refresh task type data from the database every time recurrent tasks are run.
Build is green
anlambert committed rDLDSVN8c709079ce28: replay: Ensure proper removal of external paths when deleting directory (authored by anlambert).
replay: Ensure proper removal of external paths when deleting directory
Rebase on updated D8769
olasd updated the diff for D8769: Refresh task type data from the database every time recurrent tasks are run.
Variabilize task_name
Build is green
olasd committed rDJNL1d879f1dd624: client: redact sensitive consumer settings before logging them (authored by olasd).
client: redact sensitive consumer settings before logging them
Add tests for the new absolute_cooldown
anlambert added a comment to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook.
I started looking how to implement that task.
vlorentz accepted D8769: Refresh task type data from the database every time recurrent tasks are run.
youmight want to add a variable for the value of f"load-{visit_type}", it's used four times now
vlorentz triaged T4656: AttributeError: 'NoneType' object has no attribute 'endswith' as Normal priority.
olasd requested review of D8769: Refresh task type data from the database every time recurrent tasks are run.
\o/
anlambert requested review of D8767: replay: Ensure proper removal of external paths when deleting directory.
vlorentz committed rDOBJSdf4be2d87c30: azure: Add tests based on Azurite in addition to mocks (authored by vlorentz).
azure: Add tests based on Azurite in addition to mocks
Puppet: Artifacts as lists
Build is green
vlorentz committed rDCIDXa51cbf396593: metadata: Make default tool configuration follow swh.indexer versions (authored by vlorentz).
metadata: Make default tool configuration follow swh.indexer versions
remove leftover marker
ardumont committed rDSNIPca822ba76bf5: nixguix: Reference the snippet of code to check dataset result (authored by ardumont).
nixguix: Reference the snippet of code to check dataset result
Build is green
Build is green
Install Azurite
Build is green
franckbret committed rDLS8355fee25f57: Puppet: Switch artifacts from dict to list (authored by franckbret).
Puppet: Switch artifacts from dict to list
Rebase
Harbormaster failed remote builds in B32561: Diff 31607 for D8756: azure: Add tests based on Azurite in addition to mocks!