Build has FAILED

Begone, markers

Build is green

Something like this needs to happen on content indexer too (regarding their respective tools file and nomossa).

Use 'azurite-blob' instead of 'azurite'/'azurite.js'

Build is green

In D8756#227875, @olasd wrote:

Then we should just npm install azurite container-wide on the CI system so these tests actually run on jenkins. (Alternatively, we can add a package.json / yarn.lock locally to this package, which should make jenkins automagically install it)

use AZURITE_PATH as a dir name, and switch to skipif

This seems like a great idea.

In D8759#227735, @vlorentz wrote:

Anyway, I'm guessing it will fix itself when you send any update to the diff so let's ignore that issue for now.

This looks fine to me, though we might want to use something other than SHA1 for this.

We are currently in the process of moving the objstorage to multi-hashes, so eventually we will want to use multi-hashes here too. I wonder if we should do that before landing this diff (and D8760). It would be less effort overall, but will delay your work a bit.

eg. here it could be done by making payload a dictionary (with algos as keys and digests as values), and serialize the manifest as:

[payload_type $StrWithoutSpaces]
[payload blake2s256 $Hexdigest]
[payload sha1 $Hexdigest]
[payload sha1_git $Hexdigest]
[payload sha256 $Hexdigest]

@samplet @olasd What do you think?

In D8759#227732, @vlorentz wrote:

Hi, thanks for the diffs

In D8759#227712, @samplet wrote:

It looks like using the --draft flag when sending this with arc has confused the CI system. The build failed because it couldn't access the updated code:

fatal: Couldn't find remote ref refs/tags/phabricator/diff/31582

It was because you hadn't signed the CLA when submitting the diff

Build is green

Adapt according to last review (merge variable comment, drop spurious .copy)

Build is green

• Add missing test
• Fix another test

Build has FAILED

Schema changes

Build has FAILED

Build was aborted

Rename variable parameter with a better name

• Rebase
• Refactor common code on extension detection
• Adapt docstring and commit message
• Default extensions to ignore
• Adapt constructor to extend extension to ignore if any is passed around

Build is green

Rebase

In D8762#227816, @anlambert wrote:

Looks good to me, I guess you need to update the loader too.

Looks good to me, I guess you need to update the loader too.

LGTM, one thought posted as inline comment.

Build is green

Rebase

Build is green

Rework commit message

Build is green

Add missing new archive format in test manifest

Build is green

Add dataset around newly supported tarball formats

Build is green

test fixes

Anyway, I'm guessing it will fix itself when you send any update to the diff so let's ignore that issue for now.

In D8759#227730, @swh-public-ci wrote:

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/542/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/542/console

Hi, thanks for the diffs

Build has FAILED

It looks like using the --draft flag when sending this with arc has confused the CI system. The build failed because it couldn't access the updated code:

perfect, thanks

Build is green