Support Git commits with no angle brackets in author name
Closed, MigratedEdits Locked
Actions

Assigned To

Authored By

	vlorentz
	Jan 24 2022, 2:32 PM

Description

$ git clone https://github.com/noderabbit-team/tasks
$ python3
>>> import dulwich.repo
>>> r = dulwich.repo.Repo('tasks')
>>> c = dulwich.repo.Repo('.')[b'c8a1c472c97789b44d91256d5cb8899a461a0b22')
>>> c.as_raw_string()
b'tree 3e8bd4afdc836d866ad57089ad565b5f09e38475\nparent 361db946b8e11475869a125768185fdf5b77e8b3\nauthor kapil.foss@gmail.com 1297013737 -0500\ncommitter kapil.foss@gmail.com 1297013737 -0500\nencoding utf-8\n\nmore pep8, verify archive file exists before removing, test docstring'
>>> c.author
b'kapil.foss@gmail.com 1297013737 -0500'
>>> c.author_time

Revisions and Commits

rDLDG Git loader
	Changes Planned	D7603 [WIP] Add support for commits with no author

Related Objects
Search...

Status	Assigned	Task
Migrated	gitlab-migration	T3653 Stabilize loader git
Migrated	gitlab-migration	T4659 Fix all crashes of the git loader caused by malformed git objects
Migrated	gitlab-migration	T3880 Support Git commits with no angle brackets in author name

Event Timeline

vlorentz triaged this task as Normal priority.Jan 24 2022, 2:32 PM

vlorentz created this task.

Sentry issue: SWH-LOADER-GIT-TJ

This will need a patch to Dulwich to fix properly. I'll use the opportunity to make Dulwich expose offset_bytes so we don't have to re-parse it ourselves

vlorentz claimed this task.Jan 24 2022, 2:57 PM

vlorentz updated the task description. (Show Details)Jan 24 2022, 4:27 PM

https://github.com/dulwich/dulwich/pull/927 (actually, this doesn't expose the offset_bytes yet)

vlorentz added a revision: D7603: [WIP] Add support for commits with no author.Apr 20 2022, 12:56 PM

Sentry issue: SWH-LOADER-GIT-16G

Sentry issue: SWH-LOADER-GIT-198

vlorentz added a parent task: T4659: Fix all crashes of the git loader caused by malformed git objects.Oct 26 2022, 10:31 AM

vlorentz removed vlorentz as the assignee of this task.Oct 26 2022, 11:22 AM