Differential D8771

client: redact sensitive consumer settings before logging them
ClosedPublic
Actions

Authored by olasd on Oct 25 2022, 3:56 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDJNL1d879f1dd624: client: redact sensitive consumer settings before logging them

Summary

I don't like seeing passwords in my debug logs :-)

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 25 2022, 3:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 25 2022, 3:56 PM

Build is green

Patch application report for D8771 (id=31620)

Rebasing onto 7c83ee11ec...

Current branch diff-target is up to date.

Changes applied before test

commit 1d879f1dd6247b74d7e58dd0b4bd7b498ab506f0
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Aug 8 11:58:35 2022 +0200

    client: redact sensitive consumer settings before logging them

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/230/ for more details.

Harbormaster completed remote builds in B32573: Diff 31620.Oct 25 2022, 4:00 PM

olasd requested review of this revision.Oct 25 2022, 4:00 PM

vlorentz accepted this revision.Oct 25 2022, 4:06 PM

This revision is now accepted and ready to land.Oct 25 2022, 4:06 PM

Closed by commit rDJNL1d879f1dd624: client: redact sensitive consumer settings before logging them (authored by olasd). · Explain WhyOct 25 2022, 4:45 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDJNL1d879f1dd624: client: redact sensitive consumer settings before logging them.

Revision Contents
Changeset List

Path

Size

swh/

journal/

client.py

9 lines

Diff 31624

View Options

client: redact sensitive consumer settings before logging themClosedPublicActions