Build is green
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Oct 27 2021
Oct 27 2021
swh-public-ci added a comment to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
Build is green
Drop redundant instruction
ardumont added inline comments to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
I'll let this stew for a bit so others get a chance to read through it if they'd like, but I think this would be ok to land.
swh-public-ci added a comment to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
Build is green
Build is green
Update the diff
Update the right diff
ardumont added inline comments to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
Ensure the spawn does at least instantiate the build_app without crashing.
swh-public-ci added a comment to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
Build is green
Adapt test comment to be a bit more explicit
ardumont added inline comments to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
ardumont added inline comments to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
Thanks for these updated tests! A few comments inline.
IIRC this is a custom format created by your indexer; can you change that format to simply the code here?
eg. use something based on JSON or XML; and remove the regexps and implicit state machine from the lister.
I'm assuming that dropping the fix from the commit mentioned in the description, this new test raises in some ways.
swh-public-ci added a comment to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
Build is green
ardumont added a comment to D6564: Do call consumer.commit() even if not objects have been received.
why if i may ask?
Use @olasd's commit message
ardumont retitled D6520: Add a new cli endpoint to schedule recurrent visits in Celery from wip: Bootstrap scheduler cog in charge of scheduling recurring tasks to Add a new cli endpoint to schedule recurrent visits in Celery.
ardumont updated the test plan for D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
swh-public-ci added a comment to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
Build is green
Add one test
swh-public-ci added a comment to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
Build is green
Add one test
douardda requested review of D6564: Do call consumer.commit() even if not objects have been received.
olasd committed rDSCH0c7ef27b7e05: grab_next_visits: avoid time interval calculations in PostgreSQL (authored by olasd).
grab_next_visits: avoid time interval calculations in PostgreSQL
A bit sad, but hey, thanks!
Build is green
stsp committed rDLDCVS509ac801df74: rlog: fix loading of CVS commits which have a commit ID (authored by stsp).
rlog: fix loading of CVS commits which have a commit ID
rebased patch
Build is green
stsp committed rDLDCVS0829dc3309d7: rlog: fix parsing of multiple file revisions (authored by stsp).
rlog: fix parsing of multiple file revisions
rebased patch
ardumont added a reviewer for D6563: grab_next_visits: avoid time interval calculations in PostgreSQL: Reviewers.
ah, now i got the laugh on irc ;)
stsp added a revision to T3691: Implement CVS loader: D6559: cvsclient: handle additional responses sent by server.
stsp added a revision to T3691: Implement CVS loader: D6561: rlog: fix loading of CVS commits which have a commit ID.
stsp added a revision to T3691: Implement CVS loader: D6560: rlog: fix parsing of multiple file revisions.
Build is green
stsp committed rDLDCVS6ff0b4473c2b: apply style tweaks suggested by vlorentz and reformatted by black (authored by stsp).
apply style tweaks suggested by vlorentz and reformatted by black
stsp committed rDLDCVS3a2f06b3d5fb: cvsclient: handle additional responses sent by server (authored by stsp).
cvsclient: handle additional responses sent by server
- cvsclient: handle additional responses sent by server
- apply style tweaks suggested by vlorentz and reformatted by black
ardumont updated the summary of D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
stsp committed rDLDCVSd3b3344bc26d: cvsclient: handle files which lack a trailing newline (authored by stsp).
cvsclient: handle files which lack a trailing newline
ardumont updated the summary of D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
ardumont updated the test plan for D6543: docker: Install scheduler runner which deals with recurrent tasks.
ardumont updated the diff for D6543: docker: Install scheduler runner which deals with recurrent tasks.
Sync commit message and diff description
ardumont retitled D6543: docker: Install scheduler runner which deals with recurrent tasks from docker: Install scheduler orchestrator container to docker: Install scheduler runner which deals with recurrent tasks.
ardumont updated the diff for D6543: docker: Install scheduler runner which deals with recurrent tasks.
Sync names with D6520's latest state
swh-public-ci added a comment to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
Build is green
Fix doc warning seen as error in the build.
(work around it really)
Harbormaster failed remote builds in B24725: Diff 23842 for D6520: Add a new cli endpoint to schedule recurrent visits in Celery!
swh-public-ci added a comment to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
Build has FAILED
Harbormaster failed remote builds in B24724: Diff 23841 for D6520: Add a new cli endpoint to schedule recurrent visits in Celery!
swh-public-ci added a comment to D6520: Add a new cli endpoint to schedule recurrent visits in Celery.
Build has FAILED
Squash commit and use the correct commit range
Fix test
I do prefer with val's suggested improvments.
ardumont committed rDOBJS64acd020aa7c: Instantiate a noop objstorage for testing purposes (authored by ardumont).
Instantiate a noop objstorage for testing purposes
Build is green
Rebase
Build is green
Adapt according to suggestion
In D6558#170347, @stsp wrote:perhaps we can simply do this once all the fixes are merged?
In D6558#170324, @vlorentz wrote:Could you add a test?