Current CVS loader status update:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Oct 27 2021
Looks good. Just a couple suggestions below to simplify the code
Could you add a test?
You use three similar but subtly different conditionals:
Build is green
Fix title
Let's consider this is done since 2 of 3 bullets have been canceled (for now)
New work D6395 is superseding this work.
So commandeering it and closing this.
Superseded after massive refactoring / renaming by D6396.
Superseded by https://forge.softwareheritage.org/D6395
Oct 26 2021
Build is green
adjust lookup speed results and expectations according to today's benchmark results
Build is green
comment on hardcoded value
Thanks a lot for the reviews!
Build is green
address ardrumont comments
Fixed and deployed, origin https://git.code.sf.net/u/bsomervi/hamlib.git has been successfully submitted and is currently being loaded into the archive, closing this.
Build is green
Update doctring
lgtm
Thanks for the great work.
@borisbaldassari Same as for the listers, can you please close it (bottom of the page, "abandon" revision)
@borisbaldassari Same as for the listers, can you please close this (bottom of the page, "abandon" revision in the selection box)
Thanks for the great work.
Let's keep this as is now. For next time though, please keep the old diff id around
even if you think the review is harder ;)Sure. Sorry for the mess. :-)
Looks good to me. Thanks.
Remains 3 origins still ongoing...
Sentry never reported any regression since it got marked as resolved.
So that issue was no longer relevant when i opened it, closing it as invalid.
Awesome, thx for watching it ;)
Related to T3627