working implementation, with tests

compiles but crashes

In D6424#167442, @dachary wrote:

skeleton

skeleton

In D6424#166886, @ardumont wrote:

@dachary It'd be nice if you could describe what this is about in the commit message and
the diff description (if you actually provide a commit description, then when you create
the diff, the commit message is used as a description bootstrap). I know it's more work
for you but it happens that:

1. it helps the reviewers to have some context directly here (without having to follow

between a multitude of tasks. FYI, I've followed through the task but it's not enough,
i need to also dig in that arborescence of tasks).

2. is also how we are doing that in every other modules ;)

3. the curious could learn a thing or 2 even if they don't do a proper review.

Please and thanks in advance.

Cheers,

I'm curious to know where the libcmph-dev dependency was added?

@olasd these are the failed dependencies you told me to expect, right? The missing package is ... libcmph-dev.

I'd like to create a new package ( swh-objstorage-hash) and https://docs.softwareheritage.org/devel/tutorials/add-new-package.html is presumably the guide to do that. I however do not have the required permissions: would someone be so kind as to work with me on this?

make it more readable as suggested

I agree

Trvial bugfix https://forge.softwareheritage.org/D6417

it make sense to create a dedicated swh-perfecthash package.

That I did not know, so indeed, if we need a specific wrapper for our needs, ...

In addition to being unmaintained,

this could be addressed by asking authors to be in charge of the package

SWH I guess: I don't see the difference whether it's embedded in swh-objstorage, winery or a dedicated package.

That was just a test, trash it.

tox is called with explicit -e, adding a new environment is a noop unless the matching jenkins job is updated

SWH I guess: I don't see the difference whether it's embedded in swh-objstorage, winery or a dedicated package.

Wouldn't it make sense to put the cffi-based cmph wrapper in a dedicated python module/project (not necessarily under the swh namespace)?

@olasd @douardda @thomash05 : the following passes tox -e py3 therefore it is not complete nonsense. However it raises two questions:

Throttling writes to 120MBs to reduce the pressure: