Differential D6417

setup: fix 404 url to diffusion
AcceptedPublic
Actions

Authored by dachary on Oct 6 2021, 12:07 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3522: Add winery backend: learning the codebase

Diff Detail

Repository

rDOBJSRPL Content replayer

Branch

wip-urlfix (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24251
Build 37853: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 37852: arc lint + arc unit

Event Timeline

dachary created this revision.Oct 6 2021, 12:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 6 2021, 12:07 PM

Build is green

Patch application report for D6417 (id=23333)

Rebasing onto 720b7af2bf...

Current branch diff-target is up to date.

Changes applied before test

commit 3c2ef62e8e393b21b3a58e2558593bab490888b6
Author: Loïc Dachary <loic@dachary.org>
Date:   Wed Oct 6 12:04:49 2021 +0200

    setup: fix 404 url to diffusion

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/14/ for more details.

Harbormaster completed remote builds in B24246: Diff 23333.Oct 6 2021, 12:09 PM

dachary requested review of this revision.Oct 6 2021, 12:09 PM

dachary mentioned this in T3522: Add winery backend: learning the codebase.Oct 6 2021, 12:10 PM

dachary added a task: T3522: Add winery backend: learning the codebase.

ardumont added a subscriber: ardumont.Oct 6 2021, 12:29 PM

ardumont added inline comments.

setup.py
49	This sounds more human readable. What do yout hink?
49	think?

I agree

setup.py
49	I agree !

make it more readable as suggested

Build is green

Patch application report for D6417 (id=23338)

Rebasing onto 720b7af2bf...

Current branch diff-target is up to date.

Changes applied before test

commit 1c3c61eea76c3f4a449a90fba397a40d03d41344
Author: Loïc Dachary <loic@dachary.org>
Date:   Wed Oct 6 12:04:49 2021 +0200

    setup: fix 404 url to diffusion

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/15/ for more details.

Harbormaster completed remote builds in B24251: Diff 23338.Oct 6 2021, 2:56 PM

ardumont accepted this revision.Oct 6 2021, 4:36 PM

This revision is now accepted and ready to land.Oct 6 2021, 4:36 PM