Page MenuHomeSoftware Heritage

Create swh-perfecthash module
Started, Work in Progress, NormalPublic

Description

Following the steps of https://docs.softwareheritage.org/devel/tutorials/add-new-package.html

Event Timeline

olasd triaged this task as Normal priority.Oct 6 2021, 3:38 PM
olasd created this task.
olasd changed the task status from Open to Work in Progress.Oct 6 2021, 3:52 PM
olasd updated the task description. (Show Details)

@olasd these are the failed dependencies you told me to expect, right? The missing package is ... libcmph-dev.

16:26:08    In file included from build/temp.linux-x86_64-3.7/_hash_cffi.c:570:
16:26:08    ./swh/perfecthash/hash.h:1:10: fatal error: cmph.h: No such file or directory
16:26:08     #include <cmph.h>
16:26:08              ^~~~~~~~
16:26:08    compilation terminated.
16:26:08    error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

@olasd I'd like to add dependencies to the CI job running swh-perfecthash (valgrind) so that it can verify the C implementation is clean. Would you be so kind as to point me in the right direction? I looked in https://forge.softwareheritage.org/source/swh-jenkins-jobs but could not find the keyword cmph and concluded it must be in another repository.

@olasd thanks for adding the dependencies 🎉 D6545

Now there is a need to run tox -e c for this job only. I think it means doing something similar to running mypy but not for all jobs, just this one. I'd be grateful if you could point me in the right direction.