rebase
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 10 2021
rebase
rebase
Jun 9 2021
In D5754#148712, @ardumont wrote:David explained everything already. So you can close this diff and maybe mention the commit closing this at the same time in the comment.
oops, yes, sorry i read too fast. You pushed a remote branch.
You need to follow what david said (and now i'm stopping adding noise here).
In D5754#148709, @douardda wrote:In D5754#148570, @borisbaldassari wrote:In D5754#147866, @ardumont wrote:By the way @borisbaldassari, you can push, that should land and close the diff ;)
Hum.. I pushed a couple of days ago and the diff is still open. I've probably done the wrong thing.
Changes were pushed to origin/T3334_tuleap_lister -- is that ok? should I do something else/more to automatically close the diff (and see the new lister on the master etc.)?
you probably rework your git history without updating the Diff, so phab wait for the revision it knows about to be merged in master (aka 04c0a50706e8 here), but if you modified it, another revision has been pushed in the main repo, and phab is not smart enough to detect it is actually an updated version of the diff that reached the git repo.
In D5754#148570, @borisbaldassari wrote:In D5754#147866, @ardumont wrote:By the way @borisbaldassari, you can push, that should land and close the diff ;)
Hum.. I pushed a couple of days ago and the diff is still open. I've probably done the wrong thing.
Changes were pushed to origin/T3334_tuleap_lister -- is that ok? should I do something else/more to automatically close the diff (and see the new lister on the master etc.)?
remove forgotten debugging stuff
please rework your git history, not including revisions unrelated with this diff, etc.
Jun 8 2021
fullset=# \d revision Table « public.revision » Colonne | Type | Collationnement | NULL-able | Par défaut ---------+--------------------------+-----------------+-----------+-------------------------------------- id | bigint | | not null | nextval('revision_id_seq'::regclass) sha1 | sha1_git | | not null | date | timestamp with time zone | | not null | org | bigint | | | Index : "revision_pkey" PRIMARY KEY, btree (id) "revision_sha1_key" UNIQUE CONSTRAINT, btree (sha1)
fullset=# \d C_R Table « public.c_r » Colonne | Type | Collationnement | NULL-able | Par défaut ---------+----------+-----------------+-----------+------------ cnt | bigint | | not null | revs | bigint[] | | | locs | bigint[] | | | Index : "c_r_cnt_idx" btree (cnt)
please don't include the revisions about testing the isochrone graph (nor the merge, which should not be there at all, do rebase instead) in this diff, it is unrelated and should be in a dedicated diff.
Jun 7 2021
and this needs fixing.
Jun 4 2021
Also please make sure to add a blank line between the "title" and the remaining of the git commit message (in revision 6c4f25bb8fdb "Refactor [...]")
Store the files and subdirs in dedicated lists in DirectoryEntry
fix typos (thx aeviso) and prevent the creation of a few lists
do not initialize IsochroneNode.maxdate at instanciation time
rebase
rebase
fix a "typo" reported by vlorentz (I missed before)
rebase
rebas
rebase + add a comment in the synth file to explain a bit the "weird" ts in there
allow inline comments in a synth file
I understand that, it's just it can look very weird for someone not really in the project... not sure where to add a comment to make this clear (besides the commit message)
wrong revset...
rebase
rebase
Fix the synth file...
Jun 3 2021
In D5805#148044, @vlorentz wrote:Why did you commit cmdbts2.msgpack instead of regenerating it? Is it too slow?
rebase
rebase
rebase + include a R06 revision
rebase
probably useless now with D5805 coming along.
rebas
rebase on master