Page MenuHomeSoftware Heritage

Save code now email notification for submitter
Open, NormalPublic

Description

│14:39:31     +olasd | it's not going to be an easy thing to implement                                                             │
│14:40:32     +olasd | (currently, in the backend, save code now looks "just like a regular origin update", and we have no         │
│                    | provisions to hook into the completion of these events)                                                     │
│14:41:04     +seirl | % mkdir swh-signals                                                                                         │
│14:41:21   moranegg | to track when the origin was ingested?                                                                      │
│14:41:30     +seirl | to know when to send the email                                                                              │
│14:41:32     +olasd | to trigger the email notification, yeah                                                                     │
│14:42:14     +olasd | (and ideally, you want the notification to trigger when the origin is visible on the read-only copy, so     │
│                    | really you'd need to hook into postgresql replication *mindsplosion*)

Related Objects

Event Timeline

moranegg triaged this task as Wishlist priority.Oct 2 2018, 2:45 PM
moranegg created this task.
anlambert raised the priority of this task from Wishlist to Normal.Oct 1 2019, 10:59 AM

So, these days, the frontend could keep a database of mail addresses and have a journal client listening to completed origin visit states, triggering an email send after checking that the visit is indeed available on the read-only replica.

Still slightly complicated, but I guess it's doable without architectural changes now.

I'd want to hook that up only to confirmed email addresses too, so that means keycloak integration for the initial request; again, sounds doable.

Nice to see that this is becoming doable. I'm adding T2219 as a prerequisite to this task.

A lot has changed since this was opened:

  • (various tasks): Save Code Now is well integrated with keycloack
  • T3084: requests are handled in a fast track
  • T3272 : registered users can see their own save code now requests in a dedicated view

Is this feature still needed? If yes, is it easy to implement it now?

Is this feature still needed?

I think so, some origins can be long to load into the archive (huge svn repo for instance),
having a mail notification would be of interest here.

If yes, is it easy to implement it now?

Not at the moment, we need to resolve T3286 first.

Is this feature still needed?

I think so, some origins can be long to load into the archive (huge svn repo for instance),
having a mail notification would be of interest here.

If yes, is it easy to implement it now?

Not at the moment, we need to resolve T3286 first.

Good point, let's keep this open then.