rebased
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 6 2021
Apr 6 2021
douardda updated the diff for D5413: Make pg Storage.extid_add() write extid objects to the journal.
Add explicit checks for extid being written in the journal and split the revision in 2
In D5413#137363, @vlorentz wrote:Could you add a test for the storage? All other *_add have a journal test IIRC
In D5413#137370, @ardumont wrote:lgtm
(I would have made that 2 commits with each its own perimeter, 1 for the actual perimeter, 1 to refactor the test, but whatever)
Add the weekly-planning.sh script
Apr 2 2021
Apr 2 2021
Currently, the mirror test session is running with:
easy fix: modify the replayer to ignore this 'metadata' column while inserting revisions
09:45 <+vlorentz> douardda: yes and the only way around it (short of dropping data) is T3089 09:46 -swhbot:#swh-devel- T3089 (submitter: vlorentz, owner: vlorentz, status: Open): Remove the 'metadata' column of the 'revision' table <https://forge.softwareheritage.org/T3089> 09:46 <+vlorentz> or switching to cassandra 09:46 <+vlorentz> the good news is, they couldn't be inserted in the storage either, so you can safely drop them for now
douardda triaged T3199: Mirror: key value violates unique constraint "person_fullname_idx" as High priority.
Apr 1 2021
Apr 1 2021
Mar 31 2021
Mar 31 2021
In D5387#136812, @vlorentz wrote:test coverage of the code touched by this diff isn't great
Mar 30 2021
Mar 30 2021
In D5389#136825, @vlorentz wrote:Why .hex() everywhere? Does swh-provenance use hex strings internally?
douardda added inline comments to D5337: Add a test to compare the result of revision_add() with known results.
Mar 29 2021
Mar 29 2021
douardda added reviewers for D5337: Add a test to compare the result of revision_add() with known results: zack, grouss.
looks indeed reasonable (both the 1. point and the code) thanks
Mar 26 2021
Mar 26 2021
douardda updated the diff for D5337: Add a test to compare the result of revision_add() with known results.
rebase
douardda committed rDPROV4a5a99ea7d20: Add missing mypy.ini entry for iso8601 (authored by douardda).
Add missing mypy.ini entry for iso8601
douardda updated the diff for D5337: Add a test to compare the result of revision_add() with known results.
rebase
Add missing dependency on iso8601
douardda updated the diff for D5337: Add a test to compare the result of revision_add() with known results.
rebased
douardda committed rDPROV41bc4cef338c: Fix invalid extra dependency on swh-core (authored by douardda).
Fix invalid extra dependency on swh-core
douardda updated the diff for D5337: Add a test to compare the result of revision_add() with known results.
apply vlorentz comments
douardda added inline comments to D5337: Add a test to compare the result of revision_add() with known results.
Mar 25 2021
Mar 25 2021
douardda updated the diff for D5337: Add a test to compare the result of revision_add() with known results.
refactor a bit the test
douardda requested review of D5337: Add a test to compare the result of revision_add() with known results.
douardda committed rDPROVeb524713c3d6: Refactor ProvenanceWithPathDB.insert_location() (authored by douardda).
Refactor ProvenanceWithPathDB.insert_location()
douardda committed rDPROV15e390fb66c9: Add tests for revision_add() and content_find_first() (authored by douardda).
Add tests for revision_add() and content_find_first()
douardda committed rDPROV2ec4a0ab9da6: Make ArchivePostgreSQL.directory_ls_internal close the db cursor (authored by douardda).
Make ArchivePostgreSQL.directory_ls_internal close the db cursor
douardda committed rDPROVe66d94925459: Fix the example config in the README file (authored by douardda).
Fix the example config in the README file
douardda committed rDPROVc5985c3085c0: Enforce tz-aware datetime value for RevisionEntry.date (authored by douardda).
Enforce tz-aware datetime value for RevisionEntry.date
Mar 24 2021
Mar 24 2021
douardda updated the diff for D5234: Refactor ProvenanceWithPathDB.insert_location() and add a test for revision_add().
Add forgotten test data file CMDBTS.msgpack
douardda updated the diff for D5234: Refactor ProvenanceWithPathDB.insert_location() and add a test for revision_add().
apply aeviso comments and reorder (and fix) revisions
Mar 23 2021
Mar 23 2021
douardda added inline comments to D5234: Refactor ProvenanceWithPathDB.insert_location() and add a test for revision_add().
douardda updated the diff for D5234: Refactor ProvenanceWithPathDB.insert_location() and add a test for revision_add().
Rebase and use test dataset from the CMDBTS git repo
Mar 18 2021
Mar 18 2021
douardda updated the diff for D5234: Refactor ProvenanceWithPathDB.insert_location() and add a test for revision_add().
rebase and remove the dependency on pytz
douardda added inline comments to D5234: Refactor ProvenanceWithPathDB.insert_location() and add a test for revision_add().
douardda added inline comments to D5234: Refactor ProvenanceWithPathDB.insert_location() and add a test for revision_add().
LGTM, but I would have loved to see a test dedicated to branches (and filters) with non-ascii chars (ach time I see a <str>.encode() I expect the worst... )
Mar 17 2021
Mar 17 2021
douardda requested changes to D5259: deposit:config: Update deposit server config with swh_authority_url.
Can you add a line in the commit message explaining what this swh_authority_url config entry is for? Because il looks weird to add use a real URL as value in a docker test environment...
Mar 16 2021
Mar 16 2021
douardda committed rDDATASET8a164beb6a84: Update exporters.edged to swh.model 1.0 (authored by douardda).
Update exporters.edged to swh.model 1.0
Mar 15 2021
Mar 15 2021
douardda requested changes to D5239: Add deposit info to objects added to swh-storage from metadata-only deposits.
Otherwise LGTM. I'd really like a better commit message, and probably some documentation somewhere (in docs/ maybe?) explaining these 2 levels of metadata, especially documenting the second layer, since it's crafted by the deposit.
douardda added a comment to D5239: Add deposit info to objects added to swh-storage from metadata-only deposits.
I'm not very fond of the commit message, especially the fact it describes what is not done, but not really what is done, and I find Add deposit info to objects added to swh-storage from metadata-only deposits unclear. What (type of) objects are we talking of? How is the deposit info it "added" to them?
Mar 12 2021
Mar 12 2021
douardda committed rDPROVf653eb8609d5: Fix ProvenanceWithPathDB.directory_add_to_revision() (authored by douardda).
Fix ProvenanceWithPathDB.directory_add_to_revision()
douardda committed rDPROV856f5f5f5261: Make ArchivePostgreSQL not inherit from ArchiveInterface (authored by douardda).
Make ArchivePostgreSQL not inherit from ArchiveInterface
Mar 11 2021
Mar 11 2021
douardda committed rDSTOb8e10f00cfbc: Add ExtID query support to the Storage (authored by douardda).
Add ExtID query support to the Storage
douardda committed rDSTOe83452b3577a: Import TEST_OBJECTS from swh.model instead of swh.journal (authored by douardda).
Import TEST_OBJECTS from swh.model instead of swh.journal
Add hg revisions to the test data set
douardda committed rDSTO82ce7bf07ce2: Make sure test_backfill does not depend on 2 dict keys (authored by douardda).
Make sure test_backfill does not depend on 2 dict keys
bump dep on swh.model + add a comment (as requested)
Add an ExtID object
Make sure extid_get_from_target() is immune to murmur3 collisions
Mar 10 2021
Mar 10 2021
get rid of the OBJECT_TYPE_MAP_SHORT map, as requested
Add missing support for extid in the replayer
In D4807#132570, @olasd wrote:I wonder if the TEST_OBJECTS addition will break the tests of swh.storage until D4698 lands.
Remove extid_by_extid in cassandre
Apply vlorentz and olasd's suggestions
forgot sql migration script
ExtID.target is now a CoreSWHID
Mar 9 2021
Mar 9 2021
douardda moved T2894: Restructure deposit documentation with a clearer strategy from Backlog to sponsors/clients on the Documentation board.
douardda retitled D4698: Add support for ExtID in the storage from [WIP][RFC] Add support for ExtID in the storage to Add support for ExtID in the storage.
All tests should now pass (with D4807)
Mar 8 2021
Mar 8 2021
Rebase, make ExtID a HashableObject, and remove hypothesis strategies for ExtID