Page MenuHomeSoftware Heritage

Make pg Storage.extid_add() write extid objects to the journal
ClosedPublic

Authored by douardda on Fri, Apr 2, 4:15 PM.

Details

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5413 (id=19364)

Rebasing onto 0a270d1a7a...

Current branch diff-target is up to date.
Changes applied before test
commit e27327b798ffb5fb87f269e84fb2305a76b8b734
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 2 12:56:53 2021 +0200

    Make pg Strorage.extid_add() write extid objects to the journal
    
    also merge test_replay's _check_replayed and check_replayed in a single
    function.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1241/ for more details.

Could you add a test for the storage? All other *_add have a journal test IIRC

ardumont added a subscriber: ardumont.

lgtm

(I would have made that 2 commits with each its own perimeter, 1 for the actual perimeter, 1 to refactor the test, but whatever)

This revision is now accepted and ready to land.Fri, Apr 2, 5:14 PM

lgtm

(I would have made that 2 commits with each its own perimeter, 1 for the actual perimeter, 1 to refactor the test, but whatever)

cannot merge the 2 versions of check_replayed without breaking tests (because of the previously untested missing journal stanza in the pg backend), so this is really a fix of the pg backend, which proper test is the use of the correct version of the check_replayed function.

Could you add a test for the storage? All other *_add have a journal test IIRC

let me check that

Add explicit checks for extid being written in the journal and split the revision in 2

as requested by vlorentz and ardumont.

Could you add a test for the storage? All other *_add have a journal test IIRC

let me check that

ok so doing this ^ allowed me to easily do that:

(I would have made that 2 commits with each its own perimeter, 1 for the actual perimeter, 1 to refactor the test, but whatever)

:-)

Build is green

Patch application report for D5413 (id=19399)

Rebasing onto 0a270d1a7a...

Current branch diff-target is up to date.
Changes applied before test
commit 84dcbe3d0e567157aa03e74ce724e8f3b4bc1f02
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 2 12:56:53 2021 +0200

    Merge test_replay's _check_replayed and check_replayed in a single function

commit 36a7fd34f3ba81a44df97d64b81df48a3b809629
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 6 15:57:40 2021 +0200

    Fix pg Storage.extid_add(): write ExtID objects to the journal
    
    and explicitely check for extid objects in the journal in TestStorage.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1245/ for more details.

douardda retitled this revision from Make pg Strorage.extid_add() write extid objects to the journal to Make pg Storage.extid_add() write extid objects to the journal.Tue, Apr 6, 4:33 PM