Page MenuHomeSoftware Heritage
Feed Advanced Search

Aug 27 2020

douardda committed rMSLD127b04ca0ead: 2020 onbloarding talk: add a few slides on the sw arch (authored by douardda).
2020 onbloarding talk: add a few slides on the sw arch
Aug 27 2020, 3:57 PM
douardda committed rMSLDb0680739ad08: Update general-achitecture and swh-modules-deps graphs (authored by douardda).
Update general-achitecture and swh-modules-deps graphs
Aug 27 2020, 3:57 PM
douardda added a comment to T1924: Deploy packagist Lister.

I guess this also depends on a packagist loader, which we do not have at all for now...

Aug 27 2020, 11:16 AM · Lister, Archive coverage

Aug 26 2020

douardda committed rDDOCaa1840cffc6f: Update a bit the architecture description (authored by douardda).
Update a bit the architecture description
Aug 26 2020, 5:24 PM
douardda committed rDENVeaafd57741b7: docker: add gitea and launchpad listers in the lister's conf (authored by douardda).
docker: add gitea and launchpad listers in the lister's conf
Aug 26 2020, 5:14 PM
douardda committed rDENVc183376eab6e: Remove useless objstorage config entry from conf/web.yml (authored by douardda).
Remove useless objstorage config entry from conf/web.yml
Aug 26 2020, 5:14 PM
douardda closed D3841: Remove useless objstorage config entry from conf/web.yml.
Aug 26 2020, 5:14 PM
douardda updated the diff for D3841: Remove useless objstorage config entry from conf/web.yml.

rebase + anlambert's comment

Aug 26 2020, 5:13 PM
douardda added a comment to D3841: Remove useless objstorage config entry from conf/web.yml.

While you are are on it, can you also remove the objstorage dependency in swh-web service definition inside docker-compose.yml ?

Aug 26 2020, 4:53 PM
douardda added a comment to D3844: Add a validating storage proxy, to check ids before insertion..

On the other hand, it will be computationally expensive, especially for contents.
What do you think?

Aug 26 2020, 11:53 AM
douardda added a comment to T2313: Archive git.fsfe.org (Gitea).

Also beware that the default pagination value in the gitea lister is 3 (https://forge.softwareheritage.org/source/swh-lister/browse/master/swh/lister/gitea/lister.py$23) so it is very slow.

Aug 26 2020, 11:08 AM · Archive coverage, Lister
douardda closed T1734: Create a Lister for launchpad.net as Resolved.
Aug 26 2020, 11:01 AM · Lister, Archive coverage
douardda added a comment to T2313: Archive git.fsfe.org (Gitea).

Ok I was expecting something a bit smart in explore.sapk.fr, but not really:

Aug 26 2020, 10:48 AM · Archive coverage, Lister
douardda raised the priority of T2358: Deploy launchpad lister on staging from Normal to High.
Aug 26 2020, 10:29 AM · System administration, Lister, Archive coverage
douardda added a comment to T2313: Archive git.fsfe.org (Gitea).

now we have the gitea lister, we should (upgrade swh.lister on prod and) add a few listing tasks, like this fsfe instance, as well as other instances like https://codeberg.org.

Aug 26 2020, 10:23 AM · Archive coverage, Lister

Aug 25 2020

douardda committed rDLSa97613a05635: Update the list of provided listers in the README file (authored by douardda).
Update the list of provided listers in the README file
Aug 25 2020, 6:33 PM
douardda committed rDLS7ef7425d5528: Keep plugins sorted in setup.py (authored by douardda).
Keep plugins sorted in setup.py
Aug 25 2020, 6:30 PM
douardda created D3843: Update a bit the architecture description.
Aug 25 2020, 5:09 PM
douardda committed rDDOC8fc016537fd2: Update the task-lister diagram (authored by douardda).
Update the task-lister diagram
Aug 25 2020, 5:09 PM
douardda closed D3842: Update the task-lister diagram.
Aug 25 2020, 5:09 PM
douardda committed rDDOC315ca7d02fb3: Update a bit the general archtecture diagram (authored by douardda).
Update a bit the general archtecture diagram
Aug 25 2020, 5:09 PM
douardda closed D3838: Update a bit the general archtecture diagram.
Aug 25 2020, 5:09 PM
douardda created D3842: Update the task-lister diagram.
Aug 25 2020, 4:38 PM
douardda updated the diff for D3838: Update a bit the general archtecture diagram.

small improvements

Aug 25 2020, 4:37 PM
douardda created D3841: Remove useless objstorage config entry from conf/web.yml.
Aug 25 2020, 4:13 PM
douardda updated the diff for D3838: Update a bit the general archtecture diagram.

remove the webapp->objstorage RPC link

Aug 25 2020, 4:10 PM
douardda added a comment to D3838: Update a bit the general archtecture diagram.

Aug 25 2020, 4:04 PM
douardda added a comment to D3838: Update a bit the general archtecture diagram.

Aug 25 2020, 4:02 PM
douardda added a comment to D3838: Update a bit the general archtecture diagram.

Aug 25 2020, 4:01 PM
douardda added a comment to D3838: Update a bit the general archtecture diagram.

For the record, there is not really a RPC link between the webapp and the objstorage as its use is wrapped by the content_* methods of the storage interface.
So I think you should remove that new link.

Aug 25 2020, 4:00 PM
douardda updated the diff for D3838: Update a bit the general archtecture diagram.

improve the diagram

Aug 25 2020, 3:59 PM
douardda committed rDSTO4532a4dc64e7: Add a --check-config option for cli commands (authored by douardda).
Add a --check-config option for cli commands
Aug 25 2020, 11:52 AM
douardda closed T2525: Prevent the storage server from starting in case of db version mismatch , a subtask of T2524: Storage database migration tooling, as Resolved.
Aug 25 2020, 11:52 AM · Storage manager
douardda closed T2525: Prevent the storage server from starting in case of db version mismatch as Resolved by committing rDSTO4532a4dc64e7: Add a --check-config option for cli commands.
Aug 25 2020, 11:52 AM · Storage manager
douardda committed rDSTO2a35c0bb231c: Remove the deprecated config-path option from `swh storage rpc-serve` command (authored by douardda).
Remove the deprecated config-path option from `swh storage rpc-serve` command
Aug 25 2020, 11:52 AM
douardda closed D3834: Add a --check-config option for cli commands.
Aug 25 2020, 11:52 AM
douardda created D3838: Update a bit the general archtecture diagram.
Aug 25 2020, 11:28 AM
douardda updated the diff for D3834: Add a --check-config option for cli commands.

rebase

Aug 25 2020, 10:51 AM
douardda updated the diff for D3834: Add a --check-config option for cli commands.

type annotate the new ensure_check_config helper function

Aug 25 2020, 9:52 AM

Aug 24 2020

douardda committed rDSTOcc33dd359692: Add support for a new "check_config" config option in get_storage() (authored by douardda).
Add support for a new "check_config" config option in get_storage()
Aug 24 2020, 5:24 PM
douardda closed D3832: Add support for a new "check_config" config option in get_storage().
Aug 24 2020, 5:24 PM
douardda committed rDSTO4dd9597723f0: Check for db version mismatch in PgStorage.check_config() (authored by douardda).
Check for db version mismatch in PgStorage.check_config()
Aug 24 2020, 5:24 PM
douardda closed D3831: Check for db version mismatch in PgStorage.check_config().
Aug 24 2020, 5:24 PM
douardda committed rDSTOc16ff506ad52: Add a check_dbversion() method to the Db class (authored by douardda).
Add a check_dbversion() method to the Db class
Aug 24 2020, 5:24 PM
douardda committed rDSTO629d2d10ee97: Fix pytest_plugin's database janitor: do not truncate the dbversion table (authored by douardda).
Fix pytest_plugin's database janitor: do not truncate the dbversion table
Aug 24 2020, 5:24 PM
douardda closed D3814: Add a check_dbversion() method to the Db class.
Aug 24 2020, 5:24 PM
douardda updated the diff for D3834: Add a --check-config option for cli commands.

rebase + add closes T2525 in the ci msg

Aug 24 2020, 5:01 PM
douardda updated the diff for D3832: Add support for a new "check_config" config option in get_storage().

rebase

Aug 24 2020, 5:00 PM
douardda updated the diff for D3831: Check for db version mismatch in PgStorage.check_config().

rebase

Aug 24 2020, 5:00 PM
douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

rebase

Aug 24 2020, 4:59 PM
douardda created D3834: Add a --check-config option for cli commands.
Aug 24 2020, 4:51 PM
douardda updated the diff for D3832: Add support for a new "check_config" config option in get_storage().

rebase

Aug 24 2020, 4:49 PM
douardda updated the diff for D3831: Check for db version mismatch in PgStorage.check_config().

rebase

Aug 24 2020, 4:49 PM
douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

pick the correct commit to be stashed...

Aug 24 2020, 4:48 PM
douardda updated the diff for D3832: Add support for a new "check_config" config option in get_storage().

rebase

Aug 24 2020, 4:41 PM
douardda updated the diff for D3831: Check for db version mismatch in PgStorage.check_config().

rebase

Aug 24 2020, 4:41 PM
douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

fix failed black magic as ween by ardumont

Aug 24 2020, 4:40 PM
douardda added inline comments to D3814: Add a check_dbversion() method to the Db class.
Aug 24 2020, 4:36 PM
douardda added a revision to T2525: Prevent the storage server from starting in case of db version mismatch : D3832: Add support for a new "check_config" config option in get_storage().
Aug 24 2020, 2:51 PM · Storage manager
douardda created D3832: Add support for a new "check_config" config option in get_storage().
Aug 24 2020, 2:51 PM
douardda created D3831: Check for db version mismatch in PgStorage.check_config().
Aug 24 2020, 2:50 PM
douardda triaged T2530: Write a simple "quick start" for swh-graph as High priority.
Aug 24 2020, 10:59 AM · Documentation, Compressed graph service

Aug 21 2020

douardda accepted D3824: api/identifiers: Fix endpoints documentation rendering issue.
Aug 21 2020, 11:13 AM

Aug 20 2020

douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

rebase

Aug 20 2020, 5:43 PM
douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

rebase

Aug 20 2020, 4:33 PM
douardda accepted D3812: package loader: Add the 'url' to the original_artifact extrinsic metadata..

ok but please explain why in your commit message...

Aug 20 2020, 12:57 PM
douardda accepted D3816: tests: remove invalid assertion.
Aug 20 2020, 12:55 PM
douardda accepted D3811: Import db_transaction_generator and db_transaction directly from swh-core..
Aug 20 2020, 12:53 PM
douardda abandoned D3815: Import db_transaction* from swh-core instead of swh-storage.

as reported by vlorentz, duplicate of D3811

Aug 20 2020, 12:41 PM
douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

as said in the commit message, It must be updated jointly in 30-swh-schema.sql
(including after a rebase...)

Aug 20 2020, 12:21 PM
douardda created D3815: Import db_transaction* from swh-core instead of swh-storage.
Aug 20 2020, 12:16 PM
douardda added a revision to T2525: Prevent the storage server from starting in case of db version mismatch : D3814: Add a check_dbversion() method to the Db class.
Aug 20 2020, 12:10 PM · Storage manager
douardda created D3814: Add a check_dbversion() method to the Db class.
Aug 20 2020, 12:10 PM
douardda added a comment to T2525: Prevent the storage server from starting in case of db version mismatch .

Just to make is clear, my main objective here is to have a seatbelt for the mirror scenario: prevent a mirror with updated code but not-yet-updated database from even running until the DB migration script has been executed.

Aug 20 2020, 11:16 AM · Storage manager
douardda updated the task description for T2525: Prevent the storage server from starting in case of db version mismatch .
Aug 20 2020, 11:04 AM · Storage manager
douardda updated the task description for T2525: Prevent the storage server from starting in case of db version mismatch .
Aug 20 2020, 11:02 AM · Storage manager
douardda triaged T2525: Prevent the storage server from starting in case of db version mismatch as Normal priority.
Aug 20 2020, 10:57 AM · Storage manager
douardda triaged T2524: Storage database migration tooling as Normal priority.
Aug 20 2020, 10:55 AM · Storage manager
douardda created T2524: Storage database migration tooling.
Aug 20 2020, 10:55 AM · Storage manager

Aug 19 2020

douardda committed rCDFPd7393da6304f: Update the README file (authored by douardda).
Update the README file
Aug 19 2020, 3:26 PM
douardda committed rCDFP583688082016: Use the SWH_IMAGE_TAG environment variable in docker compose files (authored by douardda).
Use the SWH_IMAGE_TAG environment variable in docker compose files
Aug 19 2020, 3:26 PM
douardda committed rCDFPcec8c07c332c: Add a build image script (authored by douardda).
Add a build image script
Aug 19 2020, 3:26 PM
douardda committed rCDFP537a2608116f: Add an example compose file with by-topic replayers (authored by douardda).
Add an example compose file with by-topic replayers
Aug 19 2020, 3:26 PM
douardda committed rCDFP853586aebd89: web: fix installed deb packages list (authored by douardda).
web: fix installed deb packages list
Aug 19 2020, 3:26 PM
douardda committed rCDFPf28b8549b99a: Use a SWH_VER argument to make it easier to rebuild the image from that point (authored by douardda).
Use a SWH_VER argument to make it easier to rebuild the image from that point
Aug 19 2020, 3:26 PM
douardda committed rCDFPfdca6d007a41: Target specific versions of the swh docker image (authored by douardda).
Target specific versions of the swh docker image
Aug 19 2020, 3:26 PM
douardda committed rCDFPd9bfc4567277: Postgresql: boost max-wall-size to 4GB (authored by douardda).
Postgresql: boost max-wall-size to 4GB
Aug 19 2020, 3:26 PM
douardda committed rCDFP47c2c01fd8a8: Update entrypoint for swh-journal > 0.1 (authored by douardda).
Update entrypoint for swh-journal > 0.1
Aug 19 2020, 3:26 PM
douardda committed rCDFPf72bc1e37e9c: Update Dockerfile (authored by douardda).
Update Dockerfile
Aug 19 2020, 3:26 PM
douardda committed rCDFP7efa6ab4b4c9: Update conf/web.yml to configure the search service (authored by douardda).
Update conf/web.yml to configure the search service
Aug 19 2020, 3:26 PM

Aug 18 2020

douardda added a comment to D3800: backfiller: remove convertion of model objects back to dicts..

Yeah but I didn't find a very satisfying solution either. Well, I guess I could do something like this:

CONVERTERS: Dict[str, Callable[[BaseDb, Dict[str, Any]], BaseModel]] = {
    **{
        type_: lambda db, obj: converter(obj)
        for (type_, converter) in object_converter_fn.items()
    },
    "directory": directory_converter,                          
    "raw_extrinsic_metadata": raw_extrinsic_metadata_converter,
    "revision": revision_converter,                            
    "release": release_converter,                              
    "snapshot": snapshot_converter,                            
}

But it's not much of an improvement

Aug 18 2020, 11:53 AM
douardda accepted D3800: backfiller: remove convertion of model objects back to dicts..

LGTM, but see my comment for a possible improvement.

Aug 18 2020, 10:51 AM
douardda added inline comments to D3800: backfiller: remove convertion of model objects back to dicts..
Aug 18 2020, 10:48 AM

Jul 31 2020

douardda accepted D3674: npm: Load the content of the API's response as extrinsic snapshot metadata..

as discussed on IRC, I'm not feeling very comfortable with the format stuff (in RawExtrinsicMetadataCore) but meh.

Jul 31 2020, 5:23 PM
douardda accepted D3676: Add a default value for RawExtrinsicMetadataCore.discovery_date.
Jul 31 2020, 4:45 PM

Jul 30 2020

douardda accepted D3645: deposit.migrations: Migrate to latest storage api change.
Jul 30 2020, 3:31 PM
douardda accepted D3641: storage*: add origin_visit_status_get(...) -> PagedResult[OriginVisitStatus].

thx

Jul 30 2020, 1:58 PM
douardda added inline comments to D3641: storage*: add origin_visit_status_get(...) -> PagedResult[OriginVisitStatus].
Jul 30 2020, 12:14 PM
douardda added inline comments to D3641: storage*: add origin_visit_status_get(...) -> PagedResult[OriginVisitStatus].
Jul 30 2020, 11:56 AM
douardda added inline comments to D3641: storage*: add origin_visit_status_get(...) -> PagedResult[OriginVisitStatus].
Jul 30 2020, 11:41 AM