lgtm but see my comments, in case you agree with them.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 10 2020
Jun 10 2020
douardda added inline comments to D3253: loader: Migrate to use origin visit status add storage endpoint.
douardda added inline comments to D3253: loader: Migrate to use origin visit status add storage endpoint.
douardda committed rDOBJSRPL599d70a487b9: Rewrite test_replay using the kafka_server fixture (authored by douardda).
Rewrite test_replay using the kafka_server fixture
douardda added inline comments to D3248: Replace swh-worker-control with a swh scheduler celery-monitor subcommand.
Jun 8 2020
Jun 8 2020
douardda committed rDLDSVN2f08b0dfb7d1: test_loader: assert returned loader status is what we expect (authored by douardda).
test_loader: assert returned loader status is what we expect
Jun 5 2020
Jun 5 2020
douardda committed rDSTO88271f80dc68: Add a replayer test for anonymized journal topics (authored by douardda).
Add a replayer test for anonymized journal topics
fix the failing test
typo
douardda committed rDSTOc75da7a90e1d: Small refactoring of the InMemoryStorage to make it more consistent (authored by douardda).
Small refactoring of the InMemoryStorage to make it more consistent
douardda committed rDOBJS15358e9c2ac5: Prevent collections.abc related deprecation warning (authored by douardda).
Prevent collections.abc related deprecation warning
Update tests to swh.model 0.3
Jun 4 2020
Jun 4 2020
oops (thx anlambert)
douardda committed rDLDBASEc28799f674e3: Fix a potential UnboundLocalError in clean_dangling_folders() (authored by douardda).
Fix a potential UnboundLocalError in clean_dangling_folders()
Adapt to swh.model 0.3
d/changelog: fix the release
d/changelog: version 0.1.0-2~swh1
d/control: update dependencies
Fix test data for swh.model 0.3
douardda committed rDSTOf9b2ca3fec14: Replace MockedJournalClient and MockedKafkaWriter by proper kafka test… (authored by douardda).
Replace MockedJournalClient and MockedKafkaWriter by proper kafka test…
Adapt to swh.model 0.3
douardda updated the diff for D3203: Replace MockedJournalClient and MockedKafkaWriter by proper kafka test scaffolding.
rebase
closed by 3d9f69444aeba903f701486d12978ea887a0a8f8
another fix for cassandra
douardda updated the diff for D3203: Replace MockedJournalClient and MockedKafkaWriter by proper kafka test scaffolding.
rebased on D3218
adapt according to ardumont's comments and (maybe) fix cassandra tests
In D3218#78437, @ardumont wrote:My understanding of the current log failure is that the cassandra returns you
"parents" as a list instead of tuple. This then is captured by the validation
proxy.probably, the pb of running tests with 'not cassandra'...
yeah ;)
Jsyk, in D3211 (which was missing the rest of your current diff), I took the
party of keeping the list type in the conversion function (you changed it to
Tuple here) cassandra.converters.revision_from_db and force the parents to be
a tuple within that function. This, to avoid having to change the
cassandra.storage implementations. As you took the other path, you need to
check the revision_get and other revision functions which builds list for that field ;)
In D3218#78434, @ardumont wrote:Build has FAILED
My understanding of the current log failure is that the cassandra returns you
"parents" as a list instead of tuple. This then is captured by the validation
proxy.
add a word in the commit message about test_api_client_dicts.py removal
Jun 3 2020
Jun 3 2020
douardda committed rDJNL64cd01fc7c04: Improve tests coverage by adding missing model types in journal_data (authored by douardda).
Improve tests coverage by adding missing model types in journal_data
Adapt test data to swh.model 0.3
douardda updated the diff for D3207: Improve tests coverage by adding missing model types in journal_data.
Adapt the code to swh.model 0.3
douardda committed rDMOD340656dd3be8: Fix origin_visit hypothesis strategies (authored by douardda).
Fix origin_visit hypothesis strategies
Jun 2 2020
Jun 2 2020
Fix MockedKafkaWriter
douardda retitled D3177: Use Tuple instead of List in model declarations from Make all model objects hashable to Use Tuple instead of List in model declarations.
ok but why move the import statement in the method?
douardda committed rDSTOeef4900db52a: Fix InMemoryStorage.origin_visit_upsert() method (authored by douardda).
Fix InMemoryStorage.origin_visit_upsert() method
rebase + rephrase the commit message
douardda added inline comments to D3203: Replace MockedJournalClient and MockedKafkaWriter by proper kafka test scaffolding.
douardda added a comment to D3203: Replace MockedJournalClient and MockedKafkaWriter by proper kafka test scaffolding.
In D3203#78052, @vlorentz wrote:This also kills test_write_replay.py file since it does not test anything
more than what is currently tested in test_replay.py.Are you sure? replay.py seems to have only fixed examples, while test_write_replay.py uses anything hypothesis generates
May 29 2020
May 29 2020
douardda committed rDMODa95646fc8786: Exclude [Skipped]Content.ctime from hash/eq computation (authored by douardda).
Exclude [Skipped]Content.ctime from hash/eq computation
May 27 2020
May 27 2020
douardda added a comment to D3179: swh-storage: README: Update necessary dependencies for test purposes.
for other systems (non debian) looks a bit weird to specify he expected location for cassandra but not for postgresql.
douardda added a comment to D3179: swh-storage: README: Update necessary dependencies for test purposes.
In D3179#77530, @ardumont wrote:I don't recall the flag needed to exclude the cassandra tests from the tox or pytest run.
That'd be great to add it in there somewhere i guess.
The commit message should at least be amended, since it does not make all model objects immutable, but only fix a couple of model classes.
@olasd any reason not to do the step 1. ? Wether or not we "fix" the remaining hashability issue by overwriting the __hash__ method, I see no harm and it makes the model (IMHO) cleaner.
Conceptually, both Snapshot.branches and Directory.entries are mappings, not arrays of objects: snapshots and directories must not contain entries with repeated names (which is something that's currently enforced for snapshots, but not for directories).
May 26 2020
May 26 2020
douardda triaged T2423: Extract the `extra_headers` away from `Revision.metadata` into a top-level immutable object as Normal priority.
May 25 2020
May 25 2020
In D3177#77360, @vlorentz wrote:We wouldn't need that if pytest had an equivalent for assertCountEqual :/
improve the commit message
In D3177#77354, @douardda wrote:In D3177#77353, @douardda wrote:In D3177#77343, @vlorentz wrote:What is the motivation for this?
Be able to create sets of revisions.
Also, having frozen objects that are modifiable seems a bit fuzzy to me, to say the least.
In D3177#77353, @douardda wrote:In D3177#77343, @vlorentz wrote:What is the motivation for this?
Be able to create sets of revisions.
In D3177#77343, @vlorentz wrote:What is the motivation for this?
Forgot to update hypothesis strategies also.
Bump dep on attrs_strict >= 0.0.7