Differential D3202

Fix InMemoryStorage.origin_visit_upsert() method
ClosedPublic
Actions

Authored by douardda on May 29 2020, 3:59 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSTOeef4900db52a: Fix InMemoryStorage.origin_visit_upsert() method

Summary

the self._origin_visits[origin_url] list was built one element too big
(since visit ids starts from 1 and not 0).

This is needed to ease writing replayer tests (by comparing these lists).

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.May 29 2020, 3:59 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 29 2020, 3:59 PM

douardda added a child revision: D3203: Replace MockedJournalClient and MockedKafkaWriter by proper kafka test scaffolding.May 29 2020, 3:59 PM

vlorentz accepted this revision.May 29 2020, 4:04 PM

This revision is now accepted and ready to land.May 29 2020, 4:04 PM

Build is green

Patch application report for D3202 (id=11367)

Rebasing onto 6c6080b4d7...

Current branch diff-target is up to date.

Changes applied before test

commit eef4900db52a391e20ab51e36bace412ac6730d8
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri May 29 14:21:55 2020 +0200

    Fix InMemoryStorage.origin_visit_upsert() method
    
    the self._origin_visits[origin_url] list was built one element too big
    (since visit ids starts from 1 and not 0).
    
    This is needed to ease writing replayer tests (by comparing these lists).

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/206/ for more details.

Harbormaster completed remote builds in B12565: Diff 11367.May 29 2020, 4:06 PM

Closed by commit rDSTOeef4900db52a: Fix InMemoryStorage.origin_visit_upsert() method (authored by douardda). · Explain WhyJun 2 2020, 2:31 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSTOeef4900db52a: Fix InMemoryStorage.origin_visit_upsert() method.