Page MenuHomeSoftware Heritage

swh-storage: README: Update necessary dependencies for test purposes
AbandonedPublic

Authored by ardumont on May 27 2020, 1:45 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

Reflects the recent README update on the swh-search module.

Related to D3147

Diff Detail

Repository
rDSTO Storage manager
Branch
update-doc
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12538
Build 19045: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 19044: arc lint + arc unit

Event Timeline

ardumont created this revision.May 27 2020, 1:45 PM

I don't recall the flag needed to exclude the cassandra tests from the tox or pytest run.
That'd be great to add it in there somewhere i guess.

Build is green

Patch application report for D3179 (id=11311)

Rebasing onto 213f1b1239...

Current branch diff-target is up to date.
Changes applied before test
commit 7424be0b4b10ffa21b52275c4047cdb93f8ac6e7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 27 13:41:28 2020 +0200

    README: Update necessary dependencies for test purposes

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/192/ for more details.

I don't recall the flag needed to exclude the cassandra tests from the tox or pytest run.
That'd be great to add it in there somewhere i guess.

pytest -m 'not cassandra'

for other systems (non debian) looks a bit weird to specify he expected location for cassandra but not for postgresql.

Maybe a dedicated section for each of those (pg and cass) would be easier?

Thanks for the flag \o/

for other systems (non debian) looks a bit weird to specify he expected location for cassandra but not for postgresql.

Yes, agreed.

cassandra is hard-coded in test.
As I did not find that for postgres, I only mentioned cass.
But ok, i'll see on how to improve on this ;)

Cheers,

ardumont updated this revision to Diff 11313.May 27 2020, 2:46 PM

Adapt according to review

I did not find what's specifically needed from postgresql cli though. So I
slightly change the sentence phrasing around cassandra. Also mentioning we can
avoid running cassandra tests specifically.

ardumont added inline comments.May 27 2020, 2:47 PM
README.md
23

heads up, I changed to postgresql-11 as current debian stable does not show a postgresql package.

Build has FAILED

Patch application report for D3179 (id=11313)

Rebasing onto 213f1b1239...

Current branch diff-target is up to date.
Changes applied before test
commit b62f69b81817c2a8ec8fed7dc84284800cf0458d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 27 13:41:28 2020 +0200

    README: Update necessary dependencies for test purposes
    
    This also adds a mention on how to avoid running the cassandra tests.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/194/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/194/console

Build is green

Patch application report for D3179 (id=11313)

Rebasing onto 213f1b1239...

Current branch diff-target is up to date.
Changes applied before test
commit b62f69b81817c2a8ec8fed7dc84284800cf0458d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 27 13:41:28 2020 +0200

    README: Update necessary dependencies for test purposes
    
    This also adds a mention on how to avoid running the cassandra tests.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/195/ for more details.

ardumont added inline comments.May 27 2020, 3:07 PM
README.md
39

/me *sighs* this comment was attached to the hardcoded /usr/sbin/cassandra/ expectations...

ardumont updated this revision to Diff 11345.May 28 2020, 1:45 PM

Rebase on latest master

ardumont edited the summary of this revision. (Show Details)May 28 2020, 1:46 PM

Build is green

Patch application report for D3179 (id=11345)

Rebasing onto 738d6489bc...

Current branch diff-target is up to date.
Changes applied before test
commit 07fd9810939d99b2d64f727a54aea73a0a336c50
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 27 13:41:28 2020 +0200

    README: Update necessary dependencies for test purposes
    
    This also adds a mention on how to avoid running the cassandra tests.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/203/ for more details.

closed by 2209d313b58626a1db6aa47b2a10bc5edb9b32f2

ardumont abandoned this revision.May 28 2020, 2:25 PM