Differential D3205

Exclude [Skipped]Content.ctime from hash/eq computation
ClosedPublic
Actions

Authored by douardda on May 29 2020, 5:18 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMODa95646fc8786: Exclude [Skipped]Content.ctime from hash/eq computation

Summary

this attribute is not an intrinsic property of a content object, so it
should not be used when comparing or hashing.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.May 29 2020, 5:18 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 29 2020, 5:18 PM

Build is green

Patch application report for D3205 (id=11372)

Rebasing onto 29312dff6d...

Current branch diff-target is up to date.

Changes applied before test

commit a95646fc8786590f05c0dae019b9b72ccb5ce912
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri May 29 17:14:31 2020 +0200

    Exclude [Skipped]Content.ctime from hash/eq computation
    
    this attribute is not an intrinsic property of a content object, so it
    should not be used when comparing or hashing.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/68/ for more details.

Harbormaster completed remote builds in B12570: Diff 11372.May 29 2020, 5:19 PM