Page MenuHomeSoftware Heritage

reach a minimum of 80% SLOC coverage across all components
Started, Work in Progress, NormalPublic

Description

Here are the remaining components below thresholds, as of the last update of this task:

|----------------------+----------+------------|
| repository           | line (%) | branch (%) |
|----------------------+----------+------------|
| swh-web (frontend)   |       71 |         52 |

Source: https://jenkins.softwareheritage.org/view/swh%20master/

Details

Differential Revisions
D1111: Add tests for swh.core.db.

Related Objects

Event Timeline

douardda created this task.Dec 4 2018, 10:27 AM
ardumont updated the task description. (Show Details)Dec 4 2018, 11:54 AM

Tip: after running Tox in a repo, run coverage report -m to show which lines are not covered.

vlorentz triaged this task as Normal priority.Dec 5 2018, 3:27 PM

For the loader mercurial, there is a module swh.loader.mercurial.loader_verifier which is not production code.
It's there to test the loader manually, so that could either be probably moved to the tests and transformed into it or removed altogether.

ardumont updated the task description. (Show Details)Dec 7 2018, 6:35 PM
ardumont updated the task description. (Show Details)
ardumont updated the task description. (Show Details)Dec 10 2018, 2:01 PM
ardumont updated the task description. (Show Details)Dec 12 2018, 2:58 PM
zack renamed this task from 80% SLOC coverage to at least 80% SLOC coverage in all components.Dec 12 2018, 3:37 PM
ardumont changed the status of subtask T1219: add tests to git loader from Open to Work in Progress.Dec 17 2018, 12:01 PM
ardumont moved this task from Backlog to in progress on the Sprint 2018 12 board.Dec 17 2018, 12:03 PM
ardumont updated the task description. (Show Details)
ardumont changed the status of subtask T1430: Add tests for the Debian loader from Open to Work in Progress.Dec 17 2018, 1:58 PM
ardumont updated the task description. (Show Details)Dec 17 2018, 3:01 PM
ardumont updated the task description. (Show Details)Dec 17 2018, 3:06 PM
ardumont changed the task status from Open to Work in Progress.Feb 19 2019, 2:44 PM
ardumont updated the task description. (Show Details)
ardumont updated the task description. (Show Details)Mar 26 2019, 1:17 PM
zack updated the task description. (Show Details)May 25 2019, 5:35 PM
zack added a subscriber: zack.

only 3% to go in -lister and -core \o/

zack renamed this task from at least 80% SLOC coverage in all components to reach a minimum of 80% SLOC coverage across all components.May 25 2019, 5:39 PM
zack added a project: Development environment.
zack updated the task description. (Show Details)Jun 12 2019, 12:23 PM
zack added a comment.Jun 12 2019, 12:25 PM

The most recent update of the state of this task has shown a regression in the journal test coverage, which, per se, is not a big deal (just a few points). But it does raise the question of how, once we have attained whatever "minimum" coverage we are OK with, we monitor overtime that there is no regression. For instance, I think that code reviews should show to the reviewers how the submitted diff affects code coverage. Ideally, reviewers should be able to so if it has a net positive or negative effect on coverage, and take that into account in their review decisions. (Which is not to say we should never accept diffs that decrease code coverage—there might be reasons to do so. But it is a data point that would be useful for reviewers to see.)

zack updated the task description. (Show Details)Jul 11 2019, 2:07 PM
ardumont updated the task description. (Show Details)Thu, Aug 29, 10:29 AM
ardumont updated the task description. (Show Details)
ardumont updated the task description. (Show Details)
anlambert updated the task description. (Show Details)Thu, Aug 29, 12:08 PM
ardumont updated the task description. (Show Details)Thu, Sep 5, 11:23 AM
ardumont updated the task description. (Show Details)
ardumont updated the task description. (Show Details)Fri, Sep 6, 11:20 AM
ardumont updated the task description. (Show Details)