Differential D1773

Convert empty author/committer name/email strings to bytes.
ClosedPublic
Actions

Authored by vlorentz on Jul 25 2019, 5:03 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDJNL4fbe6f6bb5d8: Convert empty author/committer name/email strings to bytes.

Summary

They were generated by the PyPI loader.

See also: D1772

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 25 2019, 5:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 25 2019, 5:03 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/201/ for more details.

Harbormaster completed remote builds in B7030: Diff 5989.Jul 25 2019, 5:05 PM

work on lists instead of single objects

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/202/ for more details.

Harbormaster completed remote builds in B7031: Diff 5990.Jul 25 2019, 6:32 PM

I understand the frustation of findings bugs and wanted to fix fast.
But can you at least add some tests on basic standalone functions?

Other than that, sounds good.
Cheers,

This revision now requires changes to proceed.Jul 25 2019, 8:36 PM

There are doctests

There are doctests

ok...

is that included in the coverage tooling we have on jenkins?

D1770#change-xD6YYPZMaH2q enables it

is that included in the coverage tooling we have on jenkins?

Relatedly to T1411#33210

D1770#change-xD6YYPZMaH2q enables it

Ok...

Although i don't see how that's consistent with the migration we started from nose to pytest (T1261).
Do we migrate to doctest now?

And if we choose both to have both (because why not), what's the rationale to decide what's written in what?

Do we migrate to doctest now?

No.

And if we choose both to have both (because why not), what's the rationale to decide what's written in what?

doctest are first and foremost part of the documentation, therefore they provide value to readers not familiar with the project (mostly as examples of how to use a function), so they must be easy to understand. eg. here they are all one-liners.
Them being tests is a side-effect of being good (executable) examples of how to use the function

vlorentz added a child revision: D1775: Exclude dates outside the range supported by our data model..Jul 26 2019, 2:00 PM

Ok then.

This revision is now accepted and ready to land.Jul 26 2019, 6:35 PM

rebase

This revision was landed with ongoing or failed builds.Aug 6 2019, 2:56 PM

Closed by commit rDJNL4fbe6f6bb5d8: Convert empty author/committer name/email strings to bytes. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/213/ for more details.

Harbormaster completed remote builds in B7170: Diff 6141.Aug 6 2019, 2:57 PM

Revision Contents
Changeset List

Path

Size

swh/

journal/

81 lines

Diff 6142

swh/journal/replay.py

Loading...