Page MenuHomeSoftware Heritage

Convert empty author/committer name/email strings to bytes.
ClosedPublic

Authored by vlorentz on Thu, Jul 25, 5:03 PM.

Details

Summary

They were generated by the PyPI loader.

See also: D1772

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Thu, Jul 25, 5:03 PM
vlorentz updated this revision to Diff 5990.Thu, Jul 25, 6:30 PM

work on lists instead of single objects

ardumont requested changes to this revision.Thu, Jul 25, 8:36 PM
ardumont added a subscriber: ardumont.

I understand the frustation of findings bugs and wanted to fix fast.
But can you at least add some tests on basic standalone functions?

Other than that, sounds good.
Cheers,

This revision now requires changes to proceed.Thu, Jul 25, 8:36 PM

There are doctests

ardumont added a comment.EditedThu, Jul 25, 10:34 PM

There are doctests

ok...

is that included in the coverage tooling we have on jenkins?

is that included in the coverage tooling we have on jenkins?

Relatedly to T1411#33210

D1770#change-xD6YYPZMaH2q enables it

Ok...

Although i don't see how that's consistent with the migration we started from nose to pytest (T1261).
Do we migrate to doctest now?

And if we choose both to have both (because why not), what's the rationale to decide what's written in what?

Do we migrate to doctest now?

No.

And if we choose both to have both (because why not), what's the rationale to decide what's written in what?

doctest are first and foremost part of the documentation, therefore they provide value to readers not familiar with the project (mostly as examples of how to use a function), so they must be easy to understand. eg. here they are all one-liners.
Them being tests is a side-effect of being good (executable) examples of how to use the function

ardumont accepted this revision.Fri, Jul 26, 6:35 PM

Ok then.

This revision is now accepted and ready to land.Fri, Jul 26, 6:35 PM
This revision was landed with ongoing or failed builds.Tue, Aug 6, 2:56 PM
This revision was automatically updated to reflect the committed changes.