Thanks for catching this.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 11 2020
Feb 11 2020
ardumont committed rDSTO652ecf0aeb68: storages: Refactor journal operations with a dedicated writer collab (authored by ardumont).
storages: Refactor journal operations with a dedicated writer collab
ardumont updated the diff for D2634: storages: Refactor journal operations with a dedicated writer collaborator.
Rebase and plug to master branch
Feb 10 2020
Feb 10 2020
ardumont updated the diff for D2634: storages: Refactor journal operations with a dedicated writer collaborator.
Remove unnecessary copy instruction (already converting from content object to
a new dict to ease the data key removal)
ardumont added inline comments to D2634: storages: Refactor journal operations with a dedicated writer collaborator.
ardumont updated the diff for D2634: storages: Refactor journal operations with a dedicated writer collaborator.
- Add missing types on remaining collaborator method signatures
- Remove unneeded to_dict conversion as the journal is already swh.model.model.BaseModel aware.
d/control: Update runtime dependency
ardumont retitled D2634: storages: Refactor journal operations with a dedicated writer collaborator from storages: Refactor journal operations with a dedicated writer collab to storages: Refactor journal operations with a dedicated writer collaborator.
ardumont updated the diff for D2634: storages: Refactor journal operations with a dedicated writer collaborator.
- Rebase on latest master (includes D2640)
- Squash commits
tests: Remove print statement
Feb 8 2020
Feb 8 2020
ardumont updated the diff for D2634: storages: Refactor journal operations with a dedicated writer collaborator.
- writer: Make the writer able to deal with BaseModel objects
ardumont updated the diff for D2634: storages: Refactor journal operations with a dedicated writer collaborator.
- writer: Keep the signature to only what's needed
ardumont added a comment to D2634: storages: Refactor journal operations with a dedicated writer collaborator.
Also, you could make the journal writer support model objects, so you don't have to use .to_dict() every time?
ardumont added inline comments to D2634: storages: Refactor journal operations with a dedicated writer collaborator.
Feb 7 2020
Feb 7 2020
ardumont updated the diff for D2643: storages: Refactor objstorage operations with a dedicated collaborator.
Fix
ardumont updated the diff for D2643: storages: Refactor objstorage operations with a dedicated collaborator.
Fix
ardumont updated the summary of D2634: storages: Refactor journal operations with a dedicated writer collaborator.
ardumont added a comment to D2634: storages: Refactor journal operations with a dedicated writer collaborator.
Also, you could make the journal writer support model objects, so you don't have to use .to_dict() every time?
ardumont updated the diff for D2634: storages: Refactor journal operations with a dedicated writer collaborator.
- storages: Keep journal_writer as collaborator's name
- Rebase on latest master
ardumont committed rDOBJS18020c3a56b3: objstorage: Return summary of batched object added to the store (authored by ardumont).
objstorage: Return summary of batched object added to the store
ardumont added inline comments to D2634: storages: Refactor journal operations with a dedicated writer collaborator.
ardumont added inline comments to D2634: storages: Refactor journal operations with a dedicated writer collaborator.
ardumont added inline comments to D2637: objstorage: Return summary of batched object added to the store.
ardumont updated the diff for D2637: objstorage: Return summary of batched object added to the store.
Fix
ardumont updated the diff for D2637: objstorage: Return summary of batched object added to the store.
- Rename content to object
- Fix to compute correctly the mean
ardumont added inline comments to D2637: objstorage: Return summary of batched object added to the store.
ardumont committed rDDOC5bedc683a93e: docs/developer-setup: Add missing lzip dependency (authored by ardumont).
docs/developer-setup: Add missing lzip dependency
ardumont committed rDLDG9dc60db00cef: loaders: Remove content size computation during conversion (authored by ardumont).
loaders: Remove content size computation during conversion
yeah, i don't get what you mean ;)
as usual, i just compacted code within methods but that may be irrelevant in the current context (although again, that's not in the current diff's scope either ;)
Thanks, looks good.
Feb 6 2020
Feb 6 2020
ardumont closed T1723: GNU Loader, a subtask of T1351: (periodically) ingest GNU package releases, as Resolved.
It's been done and removed... so closed.
ardumont committed rDLDHG34037a2b08a5: mercurial.loader: Simplify content conversion (authored by ardumont).
mercurial.loader: Simplify content conversion
ardumont committed rDLDSVN23865d22f0d5: loader.svn: Call storage's (skipped_)content_add endpoints (authored by ardumont).
loader.svn: Call storage's (skipped_)content_add endpoints
Update requirements
Update requirements
ardumont committed rDLDBASE588b06d8adf4: tests: Use new get_storage signature (authored by ardumont).
tests: Use new get_storage signature
ardumont committed rDLDBASE38c09a87ab04: loader.core.converters: Prefer the with open pattern to read file (authored by ardumont).
loader.core.converters: Prefer the with open pattern to read file
ardumont committed rDLDBASEfa65c2afe991: test_converters: Add coverage on prepare_contents method (authored by ardumont).
test_converters: Add coverage on prepare_contents method
test_converters: Migrate to pytest
ardumont committed rDLDBASEda15a25eaf24: loader.core/package: Call storage's (skipped_)content_add endpoints (authored by ardumont).
loader.core/package: Call storage's (skipped_)content_add endpoints
ardumont added inline comments to D2631: loader.core/package: Call storage's (skipped_)content_add endpoints.
ardumont added inline comments to D2631: loader.core/package: Call storage's (skipped_)content_add endpoints.
ardumont closed T2185: Make webapp0 use Cassandra as storage backend., a subtask of T1892: Cassandra as a storage backend, as Resolved.
Missing tests?
okay-ish but lifecycle of ES related services/objects is unclear to me.
Feb 5 2020
Feb 5 2020
ardumont added a comment to D2626: Split 'content_add' method into 'content_add' and 'skipped_content_add'..
oh yeah, i accepted the review in a first drafted version...
indexer.storage: Fix missing import
ardumont added a comment to D2627: In case of errors, return a simple dictionary instead of pickled exception..
starts to look, better ;)
ardumont added a comment to D2626: Split 'content_add' method into 'content_add' and 'skipped_content_add'..
Not finished the review but i'm side-tracked (indexer storage failing for one) by other stuff so submitting remarks for now, only small ones.
ardumont added a comment to D2623: Split Content class into two classes, for missing and non-missing contents..
- rename missing -> skipped
it avoid confusion with the terminology used in swh-storage,
as "content missing" means we never saw that content before;
while "skipped content" means we saw it but didn't ingest it
for some reason.
ardumont changed the status of T2185: Make webapp0 use Cassandra as storage backend., a subtask of T1892: Cassandra as a storage backend, from Open to Work in Progress.
ardumont changed the status of T2185: Make webapp0 use Cassandra as storage backend. from Open to Work in Progress.
storage02.euwest.azure exposes a rpc server using cassandra as storage backend.
webapp0 has been updated to use it.
ardumont closed T2183: Switch webapp0 to use swh-search instead of postgresql search., a subtask of T2185: Make webapp0 use Cassandra as storage backend., as Resolved.
azure: Add storage02.euwest.azure
ardumont added a comment to D2626: Split 'content_add' method into 'content_add' and 'skipped_content_add'..
BUILD has failed
ardumont committed rSPREc71aca6fe291: azure: Define storage node within terraform manifests (authored by ardumont).
azure: Define storage node within terraform manifests
Creation went smoothly for storage01.euwest.azure up to puppet run \m/
- Migrate to new dsl (for_each)
- Use the right debian template name
- Remove unnecessary disk definition (which failed the template creation)
- Rename the resource to the correct name euwest-server`s`
- Use the correct vm name Standard_D8s_v3