Page MenuHomeSoftware Heritage

Unify exception raised by invalid input to API endpoints.
ClosedPublic

Authored by vlorentz on Feb 5 2020, 6:39 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Summary

This is a first step toward not pickling exceptions.

Depends on D2626.

Diff Detail

Repository
rDSTO Storage manager
Branch
unify-error
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10465
Build 15592: tox-on-jenkinsJenkins
Build 15591: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 5 2020, 6:39 PM
vlorentz added inline comments.Feb 6 2020, 11:25 AM
swh/storage/retry.py
22–48

Note that I changed this function to retry all errors that aren't related to argument validation

vlorentz planned changes to this revision.Feb 6 2020, 11:55 AM
vlorentz updated this revision to Diff 9403.Feb 6 2020, 12:03 PM

fix retry proxy

vlorentz retitled this revision from [WIP] Unify exception raised by invalid input to API endpoints. to Unify exception raised by invalid input to API endpoints..Feb 6 2020, 12:09 PM
vlorentz planned changes to this revision.Feb 6 2020, 12:31 PM
vlorentz updated this revision to Diff 9406.Feb 6 2020, 1:27 PM

Convert validation exceptions raised by postgresql

ardumont accepted this revision.Feb 7 2020, 3:00 AM
This revision is now accepted and ready to land.Feb 7 2020, 3:00 AM