Page MenuHomeSoftware Heritage
Differential D2628

Unify exception raised by invalid input to API endpoints.
ClosedPublic
Actions

Authored by vlorentz on Feb 5 2020, 6:39 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Summary

This is a first step toward not pickling exceptions.

Depends on D2626.

Diff Detail

Repository
rDSTO Storage manager
Branch
unify-error
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10465
Build 15592: tox-on-jenkinsJenkins
Build 15591: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 5 2020, 6:39 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 5 2020, 6:39 PM
Harbormaster failed remote builds in B10458: Diff 9397!Feb 5 2020, 6:39 PM
swh-public-ci added a comment.Feb 5 2020, 6:39 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/964/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/964/console

vlorentz edited the summary of this revision. (Show Details)Feb 5 2020, 6:40 PM
vlorentz added a parent revision: D2626: Split 'content_add' method into 'content_add' and 'skipped_content_add'..
swh-public-ci added a comment.Feb 5 2020, 6:46 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/965/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/965/console

vlorentz added inline comments.Feb 6 2020, 11:25 AM
swh/storage/retry.py
22–48

Note that I changed this function to retry all errors that aren't related to argument validation

vlorentz planned changes to this revision.Feb 6 2020, 11:55 AM
vlorentz updated this revision to Diff 9403.Feb 6 2020, 12:03 PM

fix retry proxy

swh-public-ci added a comment.Feb 6 2020, 12:09 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/967/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/967/console

Harbormaster failed remote builds in B10463: Diff 9403!Feb 6 2020, 12:09 PM
vlorentz retitled this revision from [WIP] Unify exception raised by invalid input to API endpoints. to Unify exception raised by invalid input to API endpoints..Feb 6 2020, 12:09 PM
vlorentz planned changes to this revision.Feb 6 2020, 12:31 PM
vlorentz updated this revision to Diff 9406.Feb 6 2020, 1:27 PM

Convert validation exceptions raised by postgresql

swh-public-ci added a comment.Feb 6 2020, 1:38 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/969/ for more details.

Harbormaster completed remote builds in B10465: Diff 9406.Feb 6 2020, 1:38 PM
vlorentz added a child revision: D2630: Re-raise StorageArgumentException through API calls..Feb 6 2020, 2:22 PM
ardumont accepted this revision.Feb 7 2020, 3:00 AM
This revision is now accepted and ready to land.Feb 7 2020, 3:00 AM
vlorentz closed this revision.Feb 7 2020, 11:47 AM

Landed as 638363763aa8250e28f44a215ffce8450aa378b9.

Revision Contents
Changeset List

PathSize
swh/
storage/
cassandra/
17 lines
102 lines
5 lines
113 lines
39 lines
232 lines
tests/
61 lines
75 lines

Diff 9406

View Options

swh/storage/cassandra/cql.py

Loading...
View Options

swh/storage/cassandra/storage.py

Loading...
View Options

swh/storage/exc.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/retry.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_retry.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal