Page MenuHomeSoftware Heritage

dataset: add graph export based on kafka
Changes PlannedPublic

Authored by seirl on Wed, Feb 5, 7:02 PM.

Details

Reviewers
zack
Group Reviewers
Reviewers

Diff Detail

Repository
rDDATASET swh-dataset
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10461
Build 15585: arc lint + arc unit

Event Timeline

seirl created this revision.Wed, Feb 5, 7:02 PM
seirl updated this revision to Diff 9399.Wed, Feb 5, 7:04 PM

Remove commented out part

seirl updated this revision to Diff 9400.Wed, Feb 5, 7:08 PM

Remove useless while true

Missing tests?

swh/dataset/cli.py
1

headers date range ;)

18

,), you can drop one comma.

34

docstring so click has something relevant to display when called with no or wrong arguments.

44

You might want that to be a default list so you could parametrize the call from cli.

swh/dataset/graph.py
7

hashutil before identifiers

10

docstrings?

seirl planned changes to this revision.Tue, Feb 11, 5:40 PM
seirl added inline comments.
swh/dataset/cli.py
44

I don't think we want to do that, it would have other weird implications.