Page MenuHomeSoftware Heritage

loader.core/package: Call storage's (skipped_)content_add endpoints
ClosedPublic

Authored by ardumont on Thu, Feb 6, 3:15 PM.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Thu, Feb 6, 3:15 PM
vlorentz added inline comments.Thu, Feb 6, 3:19 PM
swh/loader/core/converters.py
19–23

I don't find the name and docstring explicit enough, but I don't have any better idea for the name :/

19–38

why not switch to passing model objects instead of converting them back to dicts?

ardumont added inline comments.Thu, Feb 6, 3:20 PM
swh/loader/core/converters.py
19

contents_for_storage, prepare_contents_for_storage?

19–38

because right now, it's not supported.
so might as well convert here to avoid impacts in other callers.

vlorentz accepted this revision.Thu, Feb 6, 3:23 PM
This revision is now accepted and ready to land.Thu, Feb 6, 3:23 PM