Page MenuHomeSoftware Heritage
Differential D2630

Re-raise StorageArgumentException through API calls.
ClosedPublic
Actions

Authored by vlorentz on Feb 6 2020, 2:22 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTO03c2a021c0d6: Re-raise StorageArgumentException through API calls.
Summary

So clients will get a nice exception looking like the
original one, instead of generic RemoteApiError.

Depends on D2628, D2627

Test Plan

No new test needed, because the current tests are broken by D2627, and this diff unbreaks them.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 6 2020, 2:22 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 6 2020, 2:22 PM
vlorentz edited the test plan for this revision. (Show Details)Feb 6 2020, 2:23 PM
vlorentz edited the test plan for this revision. (Show Details)
Harbormaster failed remote builds in B10467: Diff 9408!Feb 6 2020, 2:25 PM
swh-public-ci added a comment.Feb 6 2020, 2:25 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/972/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/972/console

ardumont accepted this revision.Feb 6 2020, 2:31 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/storage/api/client.py
1

copyright update missing.

49

please, remove the print statement

This revision is now accepted and ready to land.Feb 6 2020, 2:31 PM
vlorentz updated this revision to Diff 9411.Feb 6 2020, 2:48 PM

apply comments

Harbormaster failed remote builds in B10470: Diff 9411!Feb 6 2020, 2:49 PM
swh-public-ci added a comment.Feb 6 2020, 2:49 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/974/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/974/console

vlorentz updated this revision to Diff 9479.Feb 11 2020, 3:50 PM

use last update in D2627 to simplify code

swh-public-ci added a comment.Feb 11 2020, 4:06 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/992/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/992/console

Harbormaster failed remote builds in B10542: Diff 9479!Feb 11 2020, 4:06 PM
vlorentz updated this revision to Diff 9519.Feb 12 2020, 4:51 PM

rebase

swh-public-ci added a comment.Feb 12 2020, 5:11 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/996/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/996/console

Harbormaster failed remote builds in B10580: Diff 9519!Feb 12 2020, 5:11 PM
swh-public-ci added a comment.Feb 14 2020, 12:37 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/997/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/997/console

swh-public-ci added a comment.Feb 14 2020, 1:27 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/998/ for more details.

Harbormaster completed remote builds in B10580: Diff 9519.Feb 14 2020, 1:27 PM
Closed by commit rDSTO03c2a021c0d6: Re-raise StorageArgumentException through API calls. (authored by vlorentz). · Explain WhyFeb 14 2020, 1:27 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTO03c2a021c0d6: Re-raise StorageArgumentException through API calls..

Revision Contents
Changeset List

PathSize
swh/
storage/
api/
23 lines
6 lines

Diff 9529

View Options

swh/storage/api/client.py

Loading...
View Options

swh/storage/api/server.py

Loading...
About · Developer information · Legal