Update with correct requirements

Rebase on top of D3442

Sounds quite promising ;)

(nit: did not read the diff yet but typo on "Introduce" both in the diff description and git commit message ;)

also note that we are progressively migrate tests to pytest, so it would be better not to rely on BaseLoaderTest.

For the sake of the missing redefinitions in sql upgrade (and some missing test cases).

Rebase

Adapt according to review

Run completed.

build has FAILED

@civodul @zimoun heads up ^

Use proper version requirement on loader-core

Looks good

Using the right commit to update a diff is better.

Rebase

Patched staging nixguix loader worker with the diffs above on staging and triggered back a run.
It seems to no longer complain.

Rebase

Properly fix the test cases ¯\_(ツ)_/¯

Add test cases around the code change

If we need to support both, there should be a test for both

Add scenario that currently mimick the failure (and now it deals properly with it ;)

If we need to support both, there should be a test for both

Next issue [2]

Adapt according to review:

• Add missing f string prefix
• use .hex
• Add the necessary assert for mypy to be happy

First issue, missing a top-level "sources" entry [1]

Add swh.storage[testing] to tox.ini, tox you happy?

\m/

Looks good.

Adapt according to review

Could we make the check_snapshot function check object references recursively?