Page MenuHomeSoftware Heritage

assets/save: Try to set origin type when clicking on "Save again"
ClosedPublic

Authored by anlambert on Jul 6 2020, 2:33 PM.

Details

Summary

When clicking on the "Save again" button in save requests table, try to set
correct origin type from the origin url if possible.

This is useful when a user did not provide correct origin type initially.

Closes T2475

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jul 6 2020, 2:33 PM

Build has FAILED

Patch application report for D3429 (id=12146)

Rebasing onto 423ac84653...

Current branch diff-target is up to date.
Changes applied before test
commit 1655aee9b8a4a93ef137a7f15b1ba14035fdd940
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Jul 6 14:30:28 2020 +0200

    assets/save: Try to set origin type when clicking on "Save again"
    
    When clicking on the "Save again" button in save requests table, try to set
    correct origin type from the origin url if possible.
    
    This is useful when a user did not provide correct origin type initially.
    
    Closes T2475

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/267/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/267/console

ardumont accepted this revision.Jul 6 2020, 4:11 PM
ardumont added a subscriber: ardumont.

Looks good.

This revision is now accepted and ready to land.Jul 6 2020, 4:11 PM

Build has FAILED

Patch application report for D3429 (id=12288)

Rebasing onto 2a91164b69...

Current branch diff-target is up to date.
Changes applied before test
commit dfd9237835311c780949e19cd26fbe24f996aa11
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Jul 6 14:30:28 2020 +0200

    assets/save: Try to set origin type when clicking on "Save again"
    
    When clicking on the "Save again" button in save requests table, try to set
    correct origin type from the origin url if possible.
    
    This is useful when a user did not provide correct origin type initially.
    
    Closes T2475

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/272/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/272/console

anlambert updated this revision to Diff 12303.Jul 9 2020, 2:45 PM

Update: Fix cypress test

Build has FAILED

Patch application report for D3429 (id=12303)

Rebasing onto 2a91164b69...

Current branch diff-target is up to date.
Changes applied before test
commit 45402174a3f30e4fb08256858fe7e9213520285d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Jul 6 14:30:28 2020 +0200

    assets/save: Try to set origin type when clicking on "Save again"
    
    When clicking on the "Save again" button in save requests table, try to set
    correct origin type from the origin url if possible.
    
    This is useful when a user did not provide correct origin type initially.
    
    Closes T2475

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/273/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/273/console

anlambert updated this revision to Diff 12307.Jul 9 2020, 3:45 PM

Update: Really fix cypress test

Build is green

Patch application report for D3429 (id=12307)

Rebasing onto 2a91164b69...

Current branch diff-target is up to date.
Changes applied before test
commit 41f67245e54648b68b319aadcf336f75656fc64d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Jul 6 14:30:28 2020 +0200

    assets/save: Try to set origin type when clicking on "Save again"
    
    When clicking on the "Save again" button in save requests table, try to set
    correct origin type from the origin url if possible.
    
    This is useful when a user did not provide correct origin type initially.
    
    Closes T2475

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/274/ for more details.