Page MenuHomeSoftware Heritage
Create Task
Maniphest T2481

Migrate dvcs loader tests code to pytest
Closed, MigratedEdits Locked
Actions

Description

They are hard to maintain (and even read) in their current state.

It's an entangled boil of inherited classes whose perimeter is conflated
together (initialize svn repository, initialize loader with a given state,
etc...).

It's complicated to the point of adding a new scenario about multiple visits
loading scenario is not a simple task [1].

It'd be nice to disentangle this and also aligns with what other loaders are
now using, pytest fixtures!

Revisions and Commits

rDLDHG Mercurial loader
D3449rDLDHG391affaacbec tests: Rename resources directory to data
rDLDBASE Generic VCS/Package Loader
D3468rDLDBASE39ffcde65768 test_init: Use swh_storage fixture
D3433rDLDBASEd234a5c74c2b Move remaining common test utility functions to top-level arborescence
D3432rDLDBASE4084012c0ad7 Move common test utility function to the top-level arborescence
D3431rDLDBASE3348e522ccfd Define common test helper function

Related Objects
Search...

Event Timeline

ardumont renamed this task from Migrate dvcs loader code to pytest to Migrate dvcs loader tests code to pytest.Jul 6 2020, 1:55 PM
ardumont triaged this task as Normal priority.
ardumont created this task.
ardumont added a subtask: T2462: svn loader: Refactor tests using pytest fixtures.
ardumont updated the task description. (Show Details)
ardumont added projects: Core Loader, Git loader, Mercurial loader, SVN Loader.Jul 6 2020, 1:57 PM
ardumont added a revision: D3431: Define common test helper function.Jul 6 2020, 3:31 PM
ardumont added a revision: D3432: Move common test utility function to the top-level arborescence.
ardumont added a revision: D3433: Move remaining common test utility functions to top-level arborescence.Jul 6 2020, 3:34 PM
ardumont added a commit: rDLDBASE3348e522ccfd: Define common test helper function.Jul 6 2020, 5:18 PM
ardumont added a revision: D3440: loader.hg: Initialize and refactor deprecated tests to use pytest fixture.Jul 7 2020, 9:32 AM
ardumont added a commit: rDLDBASE4084012c0ad7: Move common test utility function to the top-level arborescence.Jul 7 2020, 10:07 AM
ardumont added a commit: rDLDBASEd234a5c74c2b: Move remaining common test utility functions to top-level arborescence.
ardumont mentioned this in rDLDSVN376161e0234e: Reuse helper function from swh.loader.core.Jul 7 2020, 12:54 PM
ardumont closed subtask T2482: Migrate git loader tests code to pytest as Resolved.Jul 7 2020, 1:08 PM
ardumont removed a revision: D3440: loader.hg: Initialize and refactor deprecated tests to use pytest fixture.
ardumont closed subtask T2486: Add missing coverage to the check-snapshot utility check function (and drop dead code) as Resolved.Jul 7 2020, 2:04 PM
ardumont added a revision: D3449: tests: Rename resources directory to data.Jul 7 2020, 4:44 PM
ardumont added a commit: rDLDHG391affaacbec: tests: Rename resources directory to data.Jul 7 2020, 5:07 PM
ardumont closed subtask T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin as Resolved.Jul 8 2020, 4:51 PM
ardumont added a revision: D3468: test_init: Use swh_storage fixture.Jul 8 2020, 4:52 PM
ardumont added a commit: rDLDBASE39ffcde65768: test_init: Use swh_storage fixture.Jul 9 2020, 9:28 AM
ardumont reopened subtask T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin as Open.Jul 10 2020, 3:44 PM
ardumont closed subtask T2488: Drop loader.core BaseLoaderTest and BaseLoaderStorageTest as Resolved.Jul 16 2020, 3:18 PM
ardumont closed subtask T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin as Resolved.Jul 20 2020, 9:16 AM
ardumont closed subtask T2483: tests: Make check-snapshot utility test function recursively check targetted object exists as Resolved.
ardumont closed this task as Resolved.Jul 27 2020, 3:20 PM
ardumont claimed this task.
ardumont added a parent task: T2221: Development workflow & code quality.
gitlab-migration changed the status of subtask T2462: svn loader: Refactor tests using pytest fixtures from Resolved to Migrated.Jan 8 2023, 4:30 PM
gitlab-migration changed the status of subtask T2482: Migrate git loader tests code to pytest from Resolved to Migrated.
gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 10:00 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

gitlab-migration changed the status of subtask T2483: tests: Make check-snapshot utility test function recursively check targetted object exists from Resolved to Migrated.Jan 8 2023, 10:00 PM
gitlab-migration changed the status of subtask T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin from Resolved to Migrated.
gitlab-migration changed the status of subtask T2486: Add missing coverage to the check-snapshot utility check function (and drop dead code) from Resolved to Migrated.
gitlab-migration changed the status of subtask T2488: Drop loader.core BaseLoaderTest and BaseLoaderStorageTest from Resolved to Migrated.
About · Developer information · Legal