Move sharable fixtures out of conftest into a dedicated pytest plugin
ClosedPublic
Actions

Authored by olasd on Jul 6 2020, 2:57 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSCHb2cbb9ba856c: Move shareable fixtures out of conftest into a dedicated pytest plugin

Summary

This avoids having to run from swh.scheduler.tests.conftest import * in other
modules, e.g. swh.lister, to import and use the swh_scheduler pytest fixture.

Test Plan

tox tests unchanged

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jul 6 2020, 2:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 6 2020, 2:57 PM

Build is green

Patch application report for D3430 (id=12148)

Rebasing onto 5b373ceb36...

Current branch diff-target is up to date.

Changes applied before test

commit 9d963c0be54460beb90bbab18d07b1f0c0efc27a
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jul 6 14:51:41 2020 +0200

    Move sharable fixtures out of conftest into a dedicated pytest plugin
    
    This avoids having to run `from swh.scheduler.tests.conftest import *` in other
    modules, e.g. swh.lister, to import and use the swh_scheduler pytest fixture.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/38/ for more details.

Harbormaster completed remote builds in B13370: Diff 12148.Jul 6 2020, 2:59 PM

olasd mentioned this in D3428: Migrate loader tests to use pytest.Jul 6 2020, 3:39 PM

ardumont mentioned this in T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin.Jul 6 2020, 3:57 PM

\m/

Thanks ;)

This revision is now accepted and ready to land.Jul 6 2020, 4:11 PM

olasd mentioned this in D3425: Introduce a simpler base pattern for lister implementations..Jul 6 2020, 4:18 PM

Reword

Build is green

Patch application report for D3430 (id=12159)

Rebasing onto 5b373ceb36...

Current branch diff-target is up to date.

Changes applied before test

commit b2cbb9ba856c5c3ad736e3170be58ad081c96d69
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jul 6 14:51:41 2020 +0200

    Move shareable fixtures out of conftest into a dedicated pytest plugin
    
    This avoids having to run `from swh.scheduler.tests.conftest import *` in other
    modules, e.g. swh.lister, to import and use the swh_scheduler pytest fixture.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/39/ for more details.

Harbormaster completed remote builds in B13379: Diff 12159.Jul 6 2020, 4:45 PM

Closed by commit rDSCHb2cbb9ba856c: Move shareable fixtures out of conftest into a dedicated pytest plugin (authored by olasd). · Explain WhyJul 6 2020, 4:47 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSCHb2cbb9ba856c: Move shareable fixtures out of conftest into a dedicated pytest plugin.

vlorentz mentioned this in D3453: tests: Use dedicated storage and scheduler fixtures.Jul 8 2020, 10:01 AM

ardumont mentioned this in rDLDBASE488b515a1c87: tests: Use dedicated storage and scheduler fixtures.Jul 8 2020, 3:19 PM