Page MenuHomeSoftware Heritage

svn loader: Refactor tests using pytest fixtures
Closed, ResolvedPublic

Description

They are hard to maintain (and even read) in their current state.

It's an entangled boil of inherited classes whose perimeter is conflated
together (initialize svn repository, initialize loader with a given state,
etc...).

It's complicated to the point of adding a new scenario about multiple visits
loading scenario is not a simple task [1].

It'd be nice to disentangle this and also aligns with what other loaders are
now using, pytest fixtures!

[1] D3307

Event Timeline

ardumont triaged this task as Normal priority.Tue, Jun 23, 3:10 PM
ardumont created this task.
ardumont added a project: SVN Loader.
ardumont closed this task as Resolved.Fri, Jul 3, 3:39 PM
ardumont claimed this task.

That fixed issues as well along the way (uneventful status, mistyped snapshot).
Redeployed a 0.2.1 version.