Page MenuHomeSoftware Heritage
Create Task
Maniphest T2486

Add missing coverage to the check-snapshot utility check function (and drop dead code)
Closed, MigratedEdits Locked
Actions

Revisions and Commits

rDLDBASE Generic VCS/Package Loader
D3444rDLDBASE3e48d63e8804 loaders.tests: Simplify and add coverage to check_snapshot

Related Objects
Search...

Event Timeline

ardumont triaged this task as Normal priority.Jul 7 2020, 9:46 AM
ardumont created this task.
ardumont mentioned this in D3433: Move remaining common test utility functions to top-level arborescence.
ardumont added a comment.Jul 7 2020, 1:09 PM

In the end, it's more dead code since it's only code we pass into when the storage used is an in-memory instance.
This is no longer the case, tests are now using pg-storage instance.

ardumont renamed this task from Add missing coverage to the check-snapshot utility check function to Add missing coverage to the check-snapshot utility check function (or drop dead code).Jul 7 2020, 1:09 PM
ardumont added a revision: D3444: loaders.tests: Simplify and add coverage to check-snapshot.Jul 7 2020, 1:16 PM
ardumont added a commit: rDLDBASE3e48d63e8804: loaders.tests: Simplify and add coverage to check_snapshot.Jul 7 2020, 2:04 PM
ardumont renamed this task from Add missing coverage to the check-snapshot utility check function (or drop dead code) to Add missing coverage to the check-snapshot utility check function (and drop dead code).Jul 7 2020, 2:04 PM
ardumont closed this task as Resolved.
ardumont claimed this task.
gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 10:00 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal