Differential D3439

loader.svn.tests: Reuse helper function from swh.loader.core
ClosedPublic
Actions

Authored by ardumont on Jul 6 2020, 6:23 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2482: Migrate git loader tests code to pytest

Commits

rDLDSVN376161e0234e: Reuse helper function from swh.loader.core

Summary

Related to T2482

Depends on D3431 D3432 D3433 D3442

Test Plan

tox

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 6 2020, 6:23 PM

Build has FAILED

Patch application report for D3439 (id=12174)

Rebasing onto a9ae83b3b1...

Current branch diff-target is up to date.

Changes applied before test

commit 6633adf51149374961a7e58b1ca5977dcf3a02a0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 6 15:44:30 2020 +0200

    Reuse helper function from swh.loader.core
    
    Related to T2481

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/67/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/67/console

Harbormaster failed remote builds in B13394: Diff 12174!Jul 6 2020, 6:24 PM

vlorentz accepted this revision.Jul 7 2020, 9:41 AM

This revision is now accepted and ready to land.Jul 7 2020, 9:41 AM

Rebase on top of D3442

ardumont edited the summary of this revision. (Show Details)Jul 7 2020, 12:41 PM

ardumont edited the test plan for this revision. (Show Details)

ardumont added a parent revision: D3442: loader.svn: Restrict swh dependencies into a buildable module.

Build has FAILED

Patch application report for D3439 (id=12188)

Could not rebase; Attempt merge onto a9ae83b3b1...

Updating a9ae83b..f3a9f33
Fast-forward
 requirements-swh.txt                |  6 +++---
 requirements-test.txt               |  1 +
 swh/loader/svn/tests/test_loader.py | 21 ++++++---------------
 3 files changed, 10 insertions(+), 18 deletions(-)

Changes applied before test

commit f3a9f333efdd1538720d545503bc1b0245971669
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 6 15:44:30 2020 +0200

    Reuse helper function from swh.loader.core
    
    Related to T2481

commit 8f7cec340735b4244f1560407b1c7d3a5a18a000
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 7 12:32:56 2020 +0200

    Restrict swh dependencies into a buildable module
    
    This fixes ci build failure [1]
    
    [1] https://jenkins.softwareheritage.org/job/DLDSVN/job/tests/718

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/69/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/69/console

Harbormaster failed remote builds in B13408: Diff 12188!Jul 7 2020, 12:41 PM

Update with correct requirements

Build is green

Patch application report for D3439 (id=12191)

Rebasing onto 8f7cec3407...

Current branch diff-target is up to date.

Changes applied before test

commit 376161e0234e877e861fc395f5819424d007fe03
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 6 15:44:30 2020 +0200

    Reuse helper function from swh.loader.core
    
    Related to T2481

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/70/ for more details.

Harbormaster completed remote builds in B13411: Diff 12191.Jul 7 2020, 12:53 PM

Closed by commit rDLDSVN376161e0234e: Reuse helper function from swh.loader.core (authored by ardumont). · Explain WhyJul 7 2020, 12:54 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVN376161e0234e: Reuse helper function from swh.loader.core.