Improve comment
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Oct 22 2021
Looks good to me, thanks ! I added a last batch of nitpick comments to handle before landing this.
Build is green
Adapt
Looks good to me, I can also reproduce the issues after click upgrade to 8.x.
After patching the swh-environment/docker/dockerfile:
Build is green
Adapt according to suggestion
Thank you, tried again, and now it works! :-)
In git annex vicfg, I've changed the profile of the saam copy of the annex to "backup". This should tell further calls to git annex sync --content to send everything there regardless of the numcopies setting. Hopefully?
Can you please provide a full log of the git annex sync --content operation? It seems that the content hasn't been pushed to saam, which hosts the copy of the data that's served through the web.
Build is green
Oct 21 2021
Build was aborted
One comment inline, but otherwise it's all good. Thanks
Build is green
Documentation updates
The deployment scripts to deploy the vault and the associated components have to be adapted to be deployed on the grid5000 cluster. work in progress...
Fix noisy characters (trailing ` and some white space)
In T3677#72924, @vlorentz wrote:Oh and another use-case we discussed: when browsing an origin/directory/..., showing on the side the set of sources that provided metadata for that origin/directory/.... This is, again, to improve discoverability.
and this one for the pathslicing stuff (may not be kept in the end).
Can you describe the purpose, design, etc. in docs/?
Build is green
Requested changes
Build is green
This is moving forward, great ! I added a couple of inline comments to handle.
Build is green
Oh and another use-case we discussed: when browsing an origin/directory/..., showing on the side the set of sources that provided metadata for that origin/directory/.... This is, again, to improve discoverability.
Can you describe the purpose, design, etc. in docs/?
rebase
Following our discussion, we might call the tag metadata-source, since using the term origin for metadata can be misleading.
In T3677#72918, @moranegg wrote:Why do we want that:
- as you analyzed: recognize the deposit in the UI
Removed unused code
Why do we want that:
- as you analyzed: recognize the deposit in the UI
- recognize in the deposit storage, what is the source (origin) of the deposit
- here it happens that the deposit itself is only metadata
- identify which deposits are metadata-only deposits
Build is green
Mmmm, ok i guess. I don't recall the reason that made it that way initially.
Changes requested in the review
Stopping here the investigations as the limit is now the hardware running cassandra (HDD). Great improvements were made compared to the first tries
Changing the cache size doesn't seem very effective for the particular workload of the loaders:
Exception some contextual differences due probably due to the different origin loaded, the performances are quite similar.
The hit ratios between the different configurations are also very close