Improve comment
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Oct 22 2021
Oct 22 2021
anlambert updated the diff for D6533: algos/revisions_walker: Handle case of revision without committer date.
ardumont requested review of D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.
Looks good to me, thanks ! I added a last batch of nitpick comments to handle before landing this.
ardumont updated the task description for T3685: Our pip usage is broken since a recent pip release.
ardumont updated the task description for T3685: Our pip usage is broken since a recent pip release.
swh-public-ci added a comment to D6536: Restrict the click version to avoid conflict version with celery's.
Build is green
ardumont updated the diff for D6536: Restrict the click version to avoid conflict version with celery's.
Adapt
ardumont updated the task description for T3685: Our pip usage is broken since a recent pip release.
Looks good to me, I can also reproduce the issues after click upgrade to 8.x.
ardumont added inline comments to D6533: algos/revisions_walker: Handle case of revision without committer date.
anlambert added inline comments to D6533: algos/revisions_walker: Handle case of revision without committer date.
ardumont updated the task description for T3154: sysadm docs: Move relevant and public doc from intranet to swh-docs.
ardumont requested review of D6536: Restrict the click version to avoid conflict version with celery's.
vsellier committed rDSNIP5411afb8619d: grid5000/cassandra: deploy the vault components (authored by vsellier).
grid5000/cassandra: deploy the vault components
ardumont committed rDDOC4e9e5ce0712e: Migrate idrac documentation to sysadm docs (authored by ardumont).
Migrate idrac documentation to sysadm docs
After patching the swh-environment/docker/dockerfile:
Build is green
Adapt according to suggestion
Thank you, tried again, and now it works! :-)
In git annex vicfg, I've changed the profile of the saam copy of the annex to "backup". This should tell further calls to git annex sync --content to send everything there regardless of the numcopies setting. Hopefully?
Can you please provide a full log of the git annex sync --content operation? It seems that the content hasn't been pushed to saam, which hosts the copy of the data that's served through the web.
Build is green
Oct 21 2021
Oct 21 2021
Harbormaster failed remote builds in B24642: Diff 23755 for D6441: Deprecate /browse/origin/log/ URLs!
Build was aborted
One comment inline, but otherwise it's all good. Thanks
ardumont updated the task description for T3684: swh-scheduler: Document the design of the scheduler in its documentation.
ardumont triaged T3684: swh-scheduler: Document the design of the scheduler in its documentation as Normal priority.
ardumont added inline comments to D6533: algos/revisions_walker: Handle case of revision without committer date.
Build is green
Documentation updates
The deployment scripts to deploy the vault and the associated components have to be adapted to be deployed on the grid5000 cluster. work in progress...
vsellier changed the status of T3683: cassandra - benchmark the vault from Open to Work in Progress.
Fix noisy characters (trailing ` and some white space)
anlambert requested review of D6535: templates/revision-info: Display author fullname when name is None.
rdicosmo renamed T3682: Public annex page does not show updated content from Public annex page does not show updated contet to Public annex page does not show updated content.
moranegg added a comment to T3677: Separate origin-source-code and provenance-metadata in the deposit.
In T3677#72924, @vlorentz wrote:Oh and another use-case we discussed: when browsing an origin/directory/..., showing on the side the set of sources that provided metadata for that origin/directory/.... This is, again, to improve discoverability.
and this one for the pathslicing stuff (may not be kept in the end).
anlambert requested review of D6533: algos/revisions_walker: Handle case of revision without committer date.
Can you describe the purpose, design, etc. in docs/?
Build is green
Requested changes
ardumont updated the title for P1205 docker-compose no longer allows override on containers from untitled to docker-compose no longer allows me to override some containers.
Build is green
vlorentz committed rDLDBASE9f8827935da6: Remove unused 'known_artifacts' code (authored by vlorentz).
Remove unused 'known_artifacts' code
This is moving forward, great ! I added a couple of inline comments to handle.
moranegg updated the task description for T3680: Modify deposit admin view to better reflect metadata-only deposits.
Build is green
vlorentz added a comment to T3677: Separate origin-source-code and provenance-metadata in the deposit.
Oh and another use-case we discussed: when browsing an origin/directory/..., showing on the side the set of sources that provided metadata for that origin/directory/.... This is, again, to improve discoverability.
Can you describe the purpose, design, etc. in docs/?
moranegg updated the task description for T3680: Modify deposit admin view to better reflect metadata-only deposits.
rebase
deposit: Remove 'parent' deposit
moranegg added a comment to T3677: Separate origin-source-code and provenance-metadata in the deposit.
Following our discussion, we might call the tag metadata-source, since using the term origin for metadata can be misleading.
vlorentz added a comment to T3677: Separate origin-source-code and provenance-metadata in the deposit.
In T3677#72918, @moranegg wrote:Why do we want that:
- as you analyzed: recognize the deposit in the UI
Removed unused code
ardumont updated the task description for T3154: sysadm docs: Move relevant and public doc from intranet to swh-docs.
ardumont updated the task description for T3154: sysadm docs: Move relevant and public doc from intranet to swh-docs.
moranegg added a comment to T3677: Separate origin-source-code and provenance-metadata in the deposit.
Why do we want that:
- as you analyzed: recognize the deposit in the UI
- recognize in the deposit storage, what is the source (origin) of the deposit
- here it happens that the deposit itself is only metadata
- identify which deposits are metadata-only deposits
ardumont updated the task description for T3154: sysadm docs: Move relevant and public doc from intranet to swh-docs.
ardumont updated the task description for T3154: sysadm docs: Move relevant and public doc from intranet to swh-docs.
ardumont updated the task description for T3154: sysadm docs: Move relevant and public doc from intranet to swh-docs.
anlambert committed rDENVaa331105560e: services/keycloak: Update keycloak_swh_setup.py script (authored by anlambert).
services/keycloak: Update keycloak_swh_setup.py script
Build is green
Mmmm, ok i guess. I don't recall the reason that made it that way initially.
Changes requested in the review
vsellier closed T3577: Parallel loaders performances , a subtask of T3357: Perform some tests of the cassandra storage on Grid5000, as Resolved.
Stopping here the investigations as the limit is now the hardware running cassandra (HDD). Great improvements were made compared to the first tries
Changing the cache size doesn't seem very effective for the particular workload of the loaders:
Exception some contextual differences due probably due to the different origin loaded, the performances are quite similar.
The hit ratios between the different configurations are also very close
anlambert committed rSPSITEe7759626904c: keycloak: Add swh.web.admin.list_deposits role to swh-web client (authored by anlambert).
keycloak: Add swh.web.admin.list_deposits role to swh-web client